Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

sg00dwin · 2020-05-11T18:53:07Z

Bug https://bugzilla.redhat.com/show_bug.cgi?id=1789610

spadgett · 2020-05-11T19:29:23Z

/cc @tlwu2013

openshift-ci-robot · 2020-05-11T19:29:24Z

@spadgett: GitHub didn't allow me to request PR reviews from the following users: tlwu2013.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tlwu2013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-05-11T19:30:07Z

/cc @itsptk

openshift-ci-robot · 2020-05-11T19:30:29Z

@sg00dwin: This pull request references Bugzilla bug 1789610, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1789610: Resolve Subscribe/Install terminology when installing operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett · 2020-05-11T19:30:57Z

@sg00dwin don't forget the Bug 1789610: prefix to make the bot happy :)

spadgett

/approve
/lgtm

spadgett · 2020-05-11T19:31:51Z

...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx

@@ -542,7 +542,7 @@ export const OperatorHubSubscribeForm: React.FC<OperatorHubSubscribeFormProps> =
        {formError()}
        <ActionGroup className="pf-c-form">
          <Button onClick={() => submit()} isDisabled={formValid()} variant="primary">
-            Subscribe
+            Install


I have a feeling this will have doc impact.

cc @ahardin-rh

spadgett · 2020-05-11T19:32:46Z

/bugzilla refresh

openshift-ci-robot · 2020-05-11T19:32:51Z

@spadgett: This pull request references Bugzilla bug 1789610, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-05-11T20:30:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-05-11T20:42:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-05-11T21:16:34Z

/lgtm cancel
Test errors

sg00dwin · 2020-05-12T13:54:02Z

/retest

itsptk · 2020-05-12T15:27:31Z

/lgtm

spadgett · 2020-05-12T20:18:30Z

/lgtm cancel

We should fix the failing tests before tagging.

benjaminapetersen · 2020-05-12T21:01:47Z

WebDriverError: unknown error: session deleted because of page crash
from unknown error: cannot determine loading status
from tab crashed
  (Session info: headless chrome=76.0.3809.0)
  (Driver info: chromedriver=76.0.3809.68 (420c9498db8ce8fcd190a954d51297672c1515d5-refs/branch-heads/3809@{#864}),platform=Linux 3.10.0-957.1.3.el7.x86_64 x86_64)
    at Object.checkLegacyResponse (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/error.js:546:15)
    at parseHttpResponse (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:509:13)
    at doSend.then.response (/go/src/github.com/openshift/console/frontend/node_modules/selenium-webdriver/lib/http.js:441:30)
    at process._tickCallback (internal/process/next_tick.js:68:7)
From: Task: WebDriver.findElements(By(css selector, [data-test-id="dashboard"]))

thats exciting :)

sg00dwin · 2020-05-13T18:22:16Z

/retest

spadgett · 2020-05-13T18:40:00Z

@sg00dwin This PR has legitimate test failures we need to fix.

Bug https://bugzilla.redhat.com/show_bug.cgi?id=1789610

sg00dwin · 2020-05-15T13:28:58Z

/retest

sg00dwin · 2020-05-15T15:10:21Z

@spadgett This finally passed and needs the lgtm

spadgett

/lgtm
/approve

openshift-ci-robot · 2020-05-18T13:39:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: itsptk, sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/operator-lifecycle-manager/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-05-18T15:09:23Z

@sg00dwin: All pull requests linked via external trackers have merged: openshift/console#5395. Bugzilla bug 1789610 has been moved to the MODIFIED state.

In response to this:

Bug 1789610: Resolve Subscribe/Install terminology when installing operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sg00dwin requested a review from rhamilto May 11, 2020 18:53

openshift-ci-robot requested a review from jeff-phillips-18 May 11, 2020 18:53

openshift-ci-robot added the component/olm Related to OLM label May 11, 2020

openshift-ci-robot requested a review from spadgett May 11, 2020 18:53

openshift-ci-robot requested a review from itsptk May 11, 2020 19:30

spadgett changed the title ~~Resolve Subscribe/Install terminology when installing operator~~ Bug 1789610: Resolve Subscribe/Install terminology when installing operator May 11, 2020

openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label May 11, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020

spadgett approved these changes May 11, 2020

View reviewed changes

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020

openshift-ci-robot assigned spadgett May 11, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2020

spadgett added this to the v4.5 milestone May 11, 2020

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 11, 2020

openshift-ci-robot assigned itsptk May 12, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020

itsptk approved these changes May 12, 2020

View reviewed changes

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2020

Resolve Subscribe/Install terminology when installing operator

6634ff5

Bug https://bugzilla.redhat.com/show_bug.cgi?id=1789610

sg00dwin force-pushed the install-operator-bug1789610 branch from 54fd886 to 6634ff5 Compare May 14, 2020 18:15

spadgett approved these changes May 18, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020

openshift-merge-robot merged commit d20138d into openshift:master May 18, 2020

sg00dwin deleted the install-operator-bug1789610 branch May 18, 2020 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

sg00dwin commented May 11, 2020

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

spadgett commented May 11, 2020

spadgett left a comment

spadgett May 11, 2020

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

openshift-bot commented May 11, 2020

openshift-bot commented May 11, 2020

spadgett commented May 11, 2020

sg00dwin commented May 12, 2020

itsptk commented May 12, 2020

spadgett commented May 12, 2020

benjaminapetersen commented May 12, 2020

sg00dwin commented May 13, 2020

spadgett commented May 13, 2020

sg00dwin commented May 15, 2020

sg00dwin commented May 15, 2020 •

edited

spadgett left a comment

openshift-ci-robot commented May 18, 2020

openshift-ci-robot commented May 18, 2020

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

Conversation

sg00dwin commented May 11, 2020

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

spadgett commented May 11, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett May 11, 2020

Choose a reason for hiding this comment

spadgett commented May 11, 2020

openshift-ci-robot commented May 11, 2020

openshift-bot commented May 11, 2020

openshift-bot commented May 11, 2020

spadgett commented May 11, 2020

sg00dwin commented May 12, 2020

itsptk commented May 12, 2020

spadgett commented May 12, 2020

benjaminapetersen commented May 12, 2020

sg00dwin commented May 13, 2020

spadgett commented May 13, 2020

sg00dwin commented May 15, 2020

sg00dwin commented May 15, 2020 • edited

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented May 18, 2020

openshift-ci-robot commented May 18, 2020

sg00dwin commented May 15, 2020 •

edited