Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

Merged
merged 1 commit into from
May 18, 2020
Merged

Bug 1789610: Resolve Subscribe/Install terminology when installing operator #5395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions frontend/packages/operator-lifecycle-manager/integration-tests/views/operator-hub.view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ export const viewInstalledOperator = () =>
.element(by.linkText('View it here.'))
.click();

export const createSubscriptionFormTitle = element(
by.cssContainingText('h1', 'Create Operator Subscription'),
);
export const createSubscriptionFormTitle = element(by.cssContainingText('h1', 'Install Operator'));
export const createSubscriptionFormName = $(
'.co-clusterserviceversion-logo__name__clusterserviceversion',
);
export const createSubscriptionFormBtn = element(by.buttonText('Subscribe'));
export const createSubscriptionFormBtn = element(by.buttonText('Install'));
export const createSubscriptionFormLoaded = () =>
browser.wait(until.visibilityOf(createSubscriptionFormBtn), 60000);
export const createSubscriptionFormInstallMode = element(
Expand Down
8 changes: 4 additions & 4 deletions ...ackages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ export const OperatorHubSubscribeForm: React.FC<OperatorHubSubscribeFormProps> =
{formError()}
<ActionGroup className="pf-c-form">
<Button onClick={() => submit()} isDisabled={formValid()} variant="primary">
Subscribe
Install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling this will have doc impact.

cc @ahardin-rh

</Button>
<Button variant="secondary" onClick={() => history.push('/operatorhub')}>
Cancel
Expand Down Expand Up @@ -590,16 +590,16 @@ export const OperatorHubSubscribePage: React.SFC<OperatorHubSubscribePageProps>
return (
<>
<Helmet>
<title>OperatorHub Subscription</title>
<title>Operator Installation</title>
</Helmet>
<div className="co-m-nav-title co-m-nav-title--breadcrumbs">
<BreadCrumbs
breadcrumbs={[
{ name: 'OperatorHub', path: `/operatorhub?${search.toString()}` },
{ name: 'Operator Subscription', path: props.match.url },
{ name: 'Operator Installation', path: props.match.url },
]}
/>
<h1 className="co-m-pane__heading">Create Operator Subscription</h1>
<h1 className="co-m-pane__heading">Install Operator</h1>
<p className="co-help-text">
Install your Operator by subscribing to one of the update channels to keep the Operator up
to date. The strategy determines either manual or automatic updates.
Expand Down