New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1834805: Support new spec changes in kafkasource #5407
Bug 1834805: Support new spec changes in kafkasource #5407
Conversation
/kind bug |
@karthikjeeyar: This pull request references Bugzilla bug 1834805, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Using existing patterns 👍 nice work!
Verified with custom operator for kafka , works as expected. @karthikjeeyar it'll be good add steps to validate as part of this PRs description . WDYT? and IMO this should go once #5430 is in |
@karthikjeeyar: This pull request references Bugzilla bug 1834805, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 similar comments
@karthikjeeyar: This pull request references Bugzilla bug 1834805, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@karthikjeeyar: This pull request references Bugzilla bug 1834805, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
11639c9
to
92e813e
Compare
@karthikjeeyar: This pull request references Bugzilla bug 1834805, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/cc @divyanshiGupta |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar, serenamarie125 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@karthikjeeyar: All pull requests linked via external trackers have merged: openshift/console#5407. Bugzilla bug 1834805 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://issues.redhat.com/browse/ODC-3788
Problem:
In v1aplha1 KafkaSource Api, spec has been changed for bootstrapServers and topics. It was string earlier and now it is changed to accept array of strings.
Solution:
As per https://github.com/knative/eventing-contrib/tree/master/kafka/source , we need to make the change in UI so that bootstrapServers and topics will accept and send array of strings.
Screenshots:
Steps to validate:
In order to install kakfa 0.15 custom operator
https://github.com/matzew/knative-kafka-operator/tree/prep_0.15#create-a-catalogsource
To install kafka
Add strimzi operator from the operatorhub or follow the example
https://knative.dev/docs/eventing/samples/kafka/
Install Knative 0.15.0 knative kafka operator from operator hub and create CR
Create kafka topic using the following yaml
Now use the kakfa cluster url and topic in the UI to create the kafka source
cluster-url: my-cluster-kafka-bootstrap.kafka:9092
topic: knative-demo-topic
Unit test coverage:
kakfasourcesection.spec.tsx
updated event-source-validation-utils.spec.ts
Broswer confromance:
cc: @openshift/team-devconsole-ux @serenamarie125