Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc-only] Update descriptor README and x-descriptors guide #5530

Merged
merged 1 commit into from
Jun 15, 2020
Merged

[Doc-only] Update descriptor README and x-descriptors guide #5530

merged 1 commit into from
Jun 15, 2020

Conversation

tlwu2013
Copy link
Contributor

@tlwu2013 tlwu2013 commented May 22, 2020 •
edited
Loading

  • in Descriptor README, add "Create Operand Form" section:
    1). Auto-generated Form
    2). Customized Creation Form with specDescriptors
    3). Ordering of Form Fields

  • in x-descriptors guide, update new descriptors + deprecate fieldGroup, arrayFieldGroup
    1). deprecate fieldGroup, arrayFieldGroup with additional examples for customizations.
    2). Add hidden
    3). Update advanced and fieldDependency use cases

@openshift-ci-robot openshift-ci-robot added component/olm Related to OLM needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 22, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @tlwu2013. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tlwu2013
Copy link
Contributor Author

Hey @TheRealJon , could you help review these doc changes?
Thanks a lot!

TheRealJon
TheRealJon requested changes May 22, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments for some grammar and wording updates and also a few improvements to clarity.

@tlwu2013 tlwu2013 requested a review from TheRealJon May 22, 2020 20:34
@spadgett
Copy link
Member

/approve
/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 28, 2020
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Jun 5, 2020

/retest

1 similar comment
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Jun 8, 2020

/retest

@tlwu2013 tlwu2013 requested a review from TheRealJon June 8, 2020 20:50
@TheRealJon
Copy link
Member

/retest

TheRealJon
TheRealJon approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 9, 2020
@spadgett
Copy link
Member

spadgett commented Jun 9, 2020

/hold

@tlwu2013 Do you mind squashing the commits?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2020
@tlwu2013 tlwu2013 force-pushed the update-readme-and-descriptors-ref branch from d47be87 to 556f810 Compare June 9, 2020 22:22
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 9, 2020
@tlwu2013
Copy link
Contributor Author

tlwu2013 commented Jun 9, 2020

Squashed, thanks @spadgett 👍 👍

@tlwu2013 tlwu2013 force-pushed the update-readme-and-descriptors-ref branch from 95b7b41 to 69187b0 Compare June 11, 2020 22:27
@TheRealJon
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon, tlwu2013

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@TheRealJon
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 970f7e8 into openshift:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
6 participants
@tlwu2013 @openshift-ci-robot @spadgett @TheRealJon @openshift-bot @openshift-merge-robot