Bug 1838698: Show alert when operator-recommended namespace already exists

[jhadvig]

Wasnt really sure if we want to somehow make "Namespace already exists" alert more informative, since the administrator might not realize the namespace isn't being created just for the operator, and other users on the cluster could already have admin access to that namespace.

Screen:

Will probably conflict with #5529

/assign @spadgett

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1838698, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1838698: Show alert when operator-recommended namespace already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1838698, which is invalid:

• expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/bugzilla refresh

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1838698, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.5.0) matches configured target release for branch (4.5.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

cc @itsptk @shawn-hurley

[spadgett]

This changes the logic for when we show the monitoring checkbox. I don't think we should show the checkbox for namespaces that already exist.

[itsptk]

It seems like now there is a risk that the user will just see the blue alert and ignore its contents since it always appears. Do either of this situations justify a warning/yellow alert? How critical is it that the user reads/understands this info? cc @tlwu2013

[tlwu2013]

@itsptk yeah, if this relates to potential security concerns (read this from Slack messages), I guess it worths being bumped up to a warning/yellow alert.

@shawn-hurley / @spadgett could you help suggest the alert text in [____] that hints users to make sure this NS isn't problematic?

Namespace openshift-logging already exists and will be used. [_____]

thanks!

[jhadvig]

@tlwu2013 @spadgett what about ?

Namespace openshift-logging already exists and will be used. Other users could already have access to this namespace.

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/operator-lifecycle-manager/OWNERS [jhadvig,spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jhadvig: All pull requests linked via external trackers have merged: openshift/console#5540. Bugzilla bug 1838698 has been moved to the MODIFIED state.

In response to this:

Bug 1838698: Show alert when operator-recommended namespace already exists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.