Bug 1838297: Creating role and roleBinding when enabling monitoring for an operator #5529
Conversation
openshift-ci-robot
added
bugzilla/severity-high
|
@jhadvig: This pull request references Bugzilla bug 1831081, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
jhadvig
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@jhadvig: This pull request references Bugzilla bug 1838297, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@jhadvig: This pull request references Bugzilla bug 1838297, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
|
||
| const createNamespaceDetails = isSuggestedNamespaceSelected && !suggestedNamespaceExists && ( |
There was a problem hiding this comment.
Here I was in an impression that we wanna show the monitoring checkbox even if the suggested namespace exists. Thats why Im PATCHing the suggested namespace in that case.
When this annotation is set to true, the OpenShift Console will update the namespace that the operator is being deployed to with the openshift.io/cluster-monitoring=true label.
There was a problem hiding this comment.
We intentionally didn't do this before because it enables monitoring for the entire namespace, and we don't know what workloads might already be running.
@shawn-hurley @bparees Any opinion on this?
There was a problem hiding this comment.
Correct, we need to be extra careful when we give folks the ability to add metrics to the cluster monitoring stack. I think that we should keep the logic that we only allow you to add monitoring if the namespace does not exist.
There was a problem hiding this comment.
I think that we should keep the logic that we only allow you to add monitoring if the namespace does not exist.
on the one hand it sounds reasonable to me, on the other hand we make no restrictions on adding workloads to a namespace that has monitoring enabled, so while we protect you in one direction(keep you from turning monitoring on when existing untrusted workloads may exist), we provide no protection in the other direction(keeping you from adding untrusted workloads to a monitored namespace). Something to think about for the future, perhaps.
There was a problem hiding this comment.
@jhadvig I think the handling of existing namespaces should be a separate change (if we want to change behavior). Let's make this PR just always create the role and role binding for a new namespace when enabling monitoring and deal with existing namespaces separately. It's a smaller change to backport as well.
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
|
@spadgett comments addressed. PTAL |
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
...d/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-subscribe.tsx
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@jhadvig: All pull requests linked via external trackers have merged: openshift/console#5529. Bugzilla bug 1838297 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@spadgett: new pull request created: #5617 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @spadgett