Bug 1840355: self-provisioner cannot find command line terminal workspace #5554
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
christianvogt
force-pushed
the
cli-ns
branch
4 times, most recently
from
c1efd5e
to
2e3a0f5
Compare
christianvogt
changed the title
openshift-ci-robot
added
bugzilla/severity-medium
|
@christianvogt: This pull request references Bugzilla bug 1840355, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@christianvogt: This pull request references Bugzilla bug 1840355, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| if (initError) { | ||
| return <LoadError message={initError} label="OpenShift command line terminal" />; | ||
| } | ||
|
|
||
| if (!loaded || (workspaceName && !initData)) { | ||
| // loading the workspace resource | ||
| if (!loaded) { |
There was a problem hiding this comment.
nit: Did we need to split it? It could've been <TerminalLoadingBox message={!loaded?"":undefined} />
There was a problem hiding this comment.
Yes it must be split because the other one is wrapped in another div for the background.
|
To test this PR, we must build the console front end and deploy the new image because the backend doesn't work with a local bridge. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@christianvogt: All pull requests linked via external trackers have merged: openshift/console#5554. Bugzilla bug 1840355 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-3794
Analysis / Root cause:
A user with only self-provisioner access is unable to list workspace resources at the cluster scope. Therefore they always get an error when trying to open the command line terminal
Solution Description:
If the user does not have access to list workspace resources at the cluster scope, loop through all available namespaces looking for a matching command line terminal namespace. Once found, save the namespace in localstorage to shortcut this lookup process in the future.
Screen shots / Gifs for design review:
No UI changes.
Unit test coverage report:
Test setup:
Depends on
#5332
openshift/console-operator#432
Browser conformance: