New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1840355: fix useCloudShellWorkspace effect re-entry when searching projects #5625
Bug 1840355: fix useCloudShellWorkspace effect re-entry when searching projects #5625
Conversation
@christianvogt: This pull request references Bugzilla bug 1840355, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@christianvogt: This pull request references Bugzilla bug 1840355, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@christianvogt: This pull request references Bugzilla bug 1840355, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rohitkrai03 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@christianvogt: All pull requests linked via external trackers have merged: openshift/console#5625, openshift/console#5554. Bugzilla bug 1840355 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
Issue related to #5554
Analysis / Root cause:
The effect to search for a valid namespace for the terminal was re-entering causing the previous search to abort early.
Solution Description:
Ensure that the dependencies to the effect, in this case the
searchNamespaces
variable, does not change while the search is in progress. When the search begins,setSearching(true)
is called. While this state istrue
we must always assignsearchNamespace
totrue
. If one of the other dependencies change, the search will stop and thensetSearching(false)
will be called in the finally clause as the effect tears down.Screen shots / Gifs for design review:
No UI change
Test setup:
Need to build console and deploy it to a cluster
Tested using cluster-bot.
Browser conformance:
cc @rohitkrai03