New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1840809: set default namespace to ALL_NAMESPACES_KEY #5621
Bug 1840809: set default namespace to ALL_NAMESPACES_KEY #5621
Conversation
@christianvogt: This pull request references Bugzilla bug 1840809, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
@christianvogt: All pull requests linked via external trackers have merged: openshift/console#5621. Bugzilla bug 1840809 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4029
Analysis / Root cause:
Default namespace is always set to
default
for new users regardless whether they have access or not.Solution Description:
Change the default namespace to the
ALL_NAMESPACES_KEY
.A new user entering the dev perspective is now redirected to: http://localhost:9000/topology/all-namespaces/graph
Updated the Add page cards to omit those whose links require a namespace. In the future we will need to revisit the Add page flows.
Other pages are covered by the start guide along with this pr for dev console: #5610
Screen shots / Gifs for design review:
Test setup:
Login with a user who has zero projects as well as one with some projects but not access to the
default
project.Test using incognito mode as to not load the previous namespace from local storage.
Browser conformance:
cc @spadgett @benjaminapetersen @invincibleJai