CNV-5024: Inform for pending changes in VM details view #5633

irosenzw · 2020-05-31T15:22:03Z

Add alerts when the user make changes in the VM details view
while the VM is running informing to restart the VM for
the changes to apply.

Additionally, the changes aren't reflected immediately on the screen
while the VM is running, like they used to be, but change after the
VM restarts. This way the screen represents the current configuration
rather than the 'future' configuration.

Signed-off-by: Ido Rosenzwig irosenzw@redhat.com

CNV-5024# Please enter the commit message for your changes. Lines starting

frontend/packages/kubevirt-plugin/src/components/vms/vm-details.tsx

atiratree · 2020-06-01T17:20:02Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-details.tsx

+                (key) =>
+                  vmConfChanges[key] && (
+                    <ListItem key={key}>
+                      <Button onClick={() => openModal(key)} isInline variant="link">


why is it better to open the modals this way? Don't we want them to go to the original modal location and just show the summary of what changed here?

frontend/packages/kubevirt-plugin/src/components/vms/vm-details.scss

frontend/packages/kubevirt-plugin/src/components/modals/vm-flavor-modal/vm-flavor-modal.tsx

frontend/packages/kubevirt-plugin/src/components/modals/boot-order-modal/boot-order-modal.tsx

atiratree · 2020-06-01T17:45:42Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

@@ -243,6 +273,15 @@ export const VMSchedulingList: React.FC<VMSchedulingListProps> = ({
  const nodeSelector = vmiLikeWrapper?.getNodeSelector();
  const tolerationsWrapperCount = (vmiLikeWrapper?.getTolerations() || []).length;
  const affinityWrapperCount = getRowsDataFromAffinity(vmiLikeWrapper?.getAffinity())?.length;
+  const vmConfChanges = detectNextRunChanges(vm, vmi);
+
+  React.useEffect(() => {


atiratree · 2020-06-01T17:46:19Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vmi-wrapper.ts


 export class VMIWrapper extends K8sResourceWrapper<VMIKind, VMIWrapper> implements VMILikeMethods {
-  constructor(vmi?: VMIKind | VMIWrapper | any, copy = false) {
+  constructor(vmi: VMIKind | VMIWrapper | any, copy = false) {


why?

it should be optional in case you want to create empty VMI

atiratree · 2020-06-01T17:51:26Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vmi-wrapper.ts

    super(VirtualMachineInstanceModel, vmi, copy);
  }

+  getVMIObj = () => this.data;


we already have a function for that

atiratree · 2020-06-01T18:00:34Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

 }) => {
-  const isVM = kindObj === VirtualMachineModel;
-  const vmiLike = isVM ? vm : vmi;
+  const vmiLike = !isVMRunningOrExpectedRunning(vm) ? vm : vmi;


this will display wrong information about VM's, once you change for example flavor

The feature is about pending changes for the next run.
If a vm is running you want to show the current configuration while the pending changes you can see it the modal - this way you can see the difference between what you have now and what will you have after restart.
It make much more sense to me.

Why does it make more sense to show the VMI configuration? and not VM configuration?

I think it is a bit weird from user perspective.

- you click on flavor
- change flavor in modal
- the flavor you clicked on is not changed
- you will start asking if I clicked cancel or save?

- also the user might expect the VM details to respect the VM yaml
- you have to click modal to see the real values
- if you are interested in the VMI view - you can find a VMI page

Anyway this change will also cause inconsistencies.
- why is it okay to show VMI cdroms and not disks?
- why do we show VMI info of scheduling part, but keeping the os for VM? plus you cannot believe the overview of scheduling modal will have something different inside

IMO, this will cause that the users will be unsure what is real info on VM's page and what is not.
Can we just show a link to VMI and describe which fields are not included in VMI configuration?

atiratree · 2020-06-01T18:05:34Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/selectors.ts

+  getVolumePersistentVolumeClaimName(getVMIVolumes(vmi).find((vol) => vol.name === diskName));
+
+export const getVMIBootableDisks = (vmi: VMIKind, defaultValue: V1Disk[] = []): V1Disk[] =>
+  getVMIDisks(vmi, defaultValue).filter((disk) => !Object.keys(disk).includes('serial'));


why are we ignoring disks with serial?

disks with serial are environment variable disks (cm, secret, sa) which aren't bootable

Other types of disks can't have serial filled?

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx

atiratree · 2020-06-02T16:44:32Z

@irosenzw can you please move this to WIP since this still has some work to be done?

matthewcarleton · 2020-06-08T16:13:53Z

fyi @irosenzw not sure how much this matters for the PR but there is a PR open here to make changes to the edit pencil icons
#5489

irosenzw · 2020-06-23T13:50:29Z

/retest

atiratree · 2020-07-22T08:38:44Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/selectors.ts

@@ -10,3 +14,14 @@ export const getVMIApiPath = (vmi: VMIKind) =>
  `${VirtualMachineInstanceModel.apiVersion}/namespaces/${getNamespace(vmi)}/${
    VirtualMachineInstanceModel.plural
  }/${getName(vmi)}`;
+
+export const getVMIPVCSourceByDisk = (vmi: VMIKind, diskName: string) =>


where are these used?

atiratree · 2020-07-22T08:39:25Z

frontend/packages/kubevirt-plugin/src/selectors/vm/selectors.ts

@@ -150,14 +150,23 @@ export const getCDRoms = (vm: VMILikeEntityKind) =>
    ? getDisks(vm as VMKind).filter((device) => !!device.cdrom)
    : getVMIDisks(vm as VMIKind).filter((device) => !!device.cdrom);

-export const getContainerImageByDisk = (vm: VMKind, name: string) =>
-  getVolumeContainerImage(getVolumes(vm).find((vol) => name === vol.name));
+export const getContainerImageByDisk = (vm: VMILikeEntityKind, name: string) =>


are these changes required? Can we keep the old version?

atiratree · 2020-07-22T08:42:53Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/devices.ts

+  return transformDevices(getVMIDisks(vmi), getVMIInterfaces(vmi));
+};
+
+const getVMIBootableDisks = (vmi: VMIKind, defaultValue: V1Disk[] = []): V1Disk[] => {


can we refactor the original function and pass just disks and volumes to it instead?

atiratree · 2020-07-22T08:43:50Z

frontend/packages/kubevirt-plugin/src/selectors/vm-like/nextRunChanges.ts

@@ -0,0 +1,181 @@
+import { VMWrapper } from '../../k8s/wrapper/vm/vm-wrapper';


let's use console conventions for naming the files

atiratree · 2020-07-22T08:59:45Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts

+    this.getVolumes().find((vol) => vol.name === volName);
+
+  getVolumesOfDisks = (disks: V1Disk[]): V1Volume[] => {
+    const diskNames = (disks || this.getDisks()).map((disk) => disk?.name);


the usage always passes disks so no need for || this.getDisks()

can we create a set here instead?

how would a set help?

atiratree · 2020-07-22T10:22:50Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.tsx

+  vmLikeEntity?: FirehoseResult<VMLikeEntityKind>;
+};
+
+const getPendingChanges = (


it already is here! Why do we have to send it from lower components?

atiratree · 2020-07-22T10:23:23Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.tsx

+): PendingChanges => ({
+  [IsPendingChange.flavor]: {
+    isPendingChange: isFlavorChanged(vmWrapper, vmiWrapper),
+    func: () => vmFlavorModal({ vmLike: vm, blocking: true }),


please let's use a better name than func

atiratree · 2020-07-22T10:24:22Z

frontend/packages/kubevirt-plugin/src/components/vm-nics/vm-nics.tsx

+  obj: vmLikeEntity,
+  customData: { updatePendingChanges },
+}) => {
+  const resources = [


this should not be necessary

atiratree · 2020-07-22T10:25:22Z

frontend/packages/kubevirt-plugin/src/components/vm-nics/vm-nics.tsx

  const [isLocked, setIsLocked] = useSafetyFirst(false);
  const withProgress = wrapWithProgress(setIsLocked);
+
+  const loadedVMIs = vmis && getLoadedData(vmis);
+  const vmi = loadedVMIs && loadedVMIs.length > 0 && loadedVMIs[0];


huh, how does this even work?

atiratree · 2020-07-22T10:27:16Z

frontend/packages/kubevirt-plugin/src/components/modals/vm-flavor-modal/vm-flavor-modal.tsx

  const inProgress = props.inProgress || !loaded;
  const vm = asVM(vmLike);
  const underlyingTemplate = getLoadedData(template);
+  const loadedVMIs = getLoadedData(vmis);
+  const vmi = loadedVMIs && loadedVMIs.length > 0 && loadedVMIs[0];


can't we just load one VMI entity?

atiratree · 2020-07-28T14:38:19Z

frontend/packages/kubevirt-plugin/src/selectors/vm-like/next-run-changes.ts

+  const vmEnvDisks = vm.getDisks().filter((dsk) => vmEnvDiskVolumeNames.includes(dsk.name));
+  const vmiEnvDisks = vmi.getDisks().filter((dsk) => vmiEnvDiskVolumeNames.includes(dsk.name));
+
+  return isDisksChanged(vm, vmi, vmEnvDisks, vmiEnvDisks);


can we use passing of just the names like we talked about?

that's not going to be enough cause for the envDisks the names aren't enough - I have to get the disks anyway.

I know, but it would be a simpler interface and you can use disks or volumes indiscriminately

atiratree · 2020-07-28T14:39:10Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/selectors.ts

@@ -10,3 +13,11 @@ export const getVMIApiPath = (vmi: VMIKind) =>
  `${VirtualMachineInstanceModel.apiVersion}/namespaces/${getNamespace(vmi)}/${
    VirtualMachineInstanceModel.plural
  }/${getName(vmi)}`;
+
+export const getVMIDataVolumeNameByDisk = (vmi: VMIKind, diskName: string): string => {


these two are not used anywhere right?

atiratree · 2020-07-28T14:40:01Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/devices.ts

+  return transformDevices(getVMIDisks(vmi), getVMIInterfaces(vmi));
+};
+
+const getVMIBootableDisks = (vmi: VMIKind): V1Disk[] => {


this one is not used

atiratree · 2020-07-28T14:40:15Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/devices.ts

+  return getBootableDisks(null, getVMIVolumes(vmi), getVMIDisks(vmi));
+};
+
+export const getVMIBootableDevices = (vmi: VMIKind): BootableDeviceType[] => {


atiratree · 2020-07-28T14:48:12Z

frontend/packages/kubevirt-plugin/src/components/vm-status/vm-status.tsx

-  if (isPaused) {
+  if (arePendingChanges) {
+    icon = YellowExclamationTriangleIcon;
+  } else if (isPaused) {
    icon = PausedIcon;
  } else if (status === VMStatusEnum.RUNNING) {
    icon = SyncAltIcon;


it should go under this if, this component should not show pending changes for other states and prefer errors etc

atiratree · 2020-07-28T14:53:15Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts

+    const thisResource = this.asResource();
+
+    if (!omitRuntimeData) {
+      return _.isEqual(thisResource, volume);


you can use this.data instead

atiratree · 2020-07-28T14:54:05Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts

@@ -143,4 +144,33 @@ export class VolumeWrapper extends ObjectWithTypePropertyWrapper<
        return null;
    }
  }
+
+  areVolumesEqual = (volume: V1Volume, omitRuntimeData?: boolean) => {


Suggested change

areVolumesEqual = (volume: V1Volume, omitRuntimeData?: boolean) => {

areVolumesEqual = (otherVolume: V1Volume, omitRuntimeData?: boolean) => {

or just other?

could we do the same for disks?

atiratree · 2020-07-28T14:56:30Z

frontend/packages/kubevirt-plugin/src/selectors/vm-like/next-run-changes.ts

+
+  return !vmVolumes.every((vol) => {
+    const vmDisk = vmDiskLookup[vol.name];
+    const diskWrapper = new DiskWrapper(vmDisk);


this can be on one line

atiratree · 2020-07-28T14:57:58Z

frontend/packages/kubevirt-plugin/src/selectors/vm-like/next-run-changes.ts

+    const vmiDevices = getVMIDevices(vmi.asResource());
+
+    let isDevsEqual = true;
+    vmDevices.forEach((bootableDevice, index) => {


it would be easier to use every or some here

atiratree · 2020-07-28T14:58:48Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/disk-wrapper.ts

+
+    const thisResource = this.asResource();
+
+    if (!omitRuntimeData) {


you can move this to the beginning

atiratree · 2020-07-28T15:02:56Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vmi-wrapper.ts

@@ -41,6 +43,14 @@ export class VMIWrapper extends K8sResourceWrapper<VMIKind, VMIWrapper> implemen

  getVolumes = (defaultValue = []) => getVMIVolumes(this.data, defaultValue);

+  getVolumeByName = (volName: string): V1Volume =>


atiratree · 2020-07-28T15:03:04Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts

@@ -60,20 +60,30 @@ export class VMWrapper extends K8sResourceWrapper<VMKind, VMWrapper> implements

  getVolumes = (defaultValue = []) => getVolumes(this.data, defaultValue);

+  getVolumeByName = (volName: string): V1Volume =>


atiratree · 2020-07-28T15:03:43Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/vm-wrapper.ts

+  getVolumesByType = (volType: VolumeType): V1Volume[] =>
+    this.getVolumes().filter((vol) => new VolumeWrapper(vol).getType() === volType);
+
+  getConfigMaps = (): V1Volume[] => this.getVolumesByType(VolumeType.CONFIG_MAP);


atiratree · 2020-07-28T15:04:58Z

frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx

+          vm={vm}
+          vmi={vmi}
+          vmStatusBundle={vmStatusBundle}
+          arePendingChanges={arePendingChanges && isVMRunningOrExpectedRunning(vm)}


note: this can cause to be evaluated to true even when VM is not in a running state

atiratree · 2020-07-28T15:05:37Z

frontend/packages/kubevirt-plugin/src/components/vms/vm.tsx

+          vmStatusBundle={vmStatusBundle}
+          arePendingChanges={arePendingChanges && isVMRunningOrExpectedRunning(vm)}
+        />
+        {isVMRunningOrExpectedRunning(vm) && arePendingChanges && <div>Pending changes</div>}


can we make one boolean out of this?

atiratree · 2020-07-28T16:24:37Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.tsx

+import { VirtualMachineModel, VirtualMachineInstanceModel } from '../../models';
+
+import './pending-changes-warning.scss';
+import { PENDING_CHANGES_WARNING_MESSAGE } from '../../strings/vm/status';


atiratree · 2020-07-28T16:24:47Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.scss

+.kv-warning-changed-attrs {
+    display: flex;
+    flex-direction: row;
+}


atiratree · 2020-07-28T16:26:59Z

frontend/packages/kubevirt-plugin/src/components/modals/vm-flavor-modal/vm-flavor-modal.tsx

+    kind: VirtualMachineInstanceModel.kind,
+    namespace: getNamespace(vmLike),
+    prop: 'vmis',
+    isList: true,


can we just load the one entity we need?

atiratree · 2020-07-28T16:28:56Z

frontend/packages/kubevirt-plugin/src/components/modals/cdrom-vm-modal/vm-cdrom-modal.tsx

+    {
+      kind: VirtualMachineInstanceModel.kind,
+      namespace: getNamespace(asVM(vmLikeEntity)),
+      prop: 'vmis',


atiratree · 2020-07-28T16:29:15Z

frontend/packages/kubevirt-plugin/src/components/modals/cdrom-vm-modal/cdrom-modal.tsx

  } = props;
  const vm = asVM(vmLikeEntity);

  const [storageClassConfigMap, isStorageClassConfigMapLoaded] = useStorageClassConfigMap();
  const inProgress = _inProgress || !isStorageClassConfigMapLoaded;
+  const loadedVMIs = getLoadedData(vmis);
+  const vmi = loadedVMIs && loadedVMIs.length > 0 && loadedVMIs[0];


atiratree · 2020-07-29T17:53:14Z

frontend/packages/kubevirt-plugin/src/selectors/vmi/selectors.ts

@@ -10,3 +11,6 @@ export const getVMIApiPath = (vmi: VMIKind) =>
  `${VirtualMachineInstanceModel.apiVersion}/namespaces/${getNamespace(vmi)}/${
    VirtualMachineInstanceModel.plural
  }/${getName(vmi)}`;
+
+export const getVMIURLSourceByDisk = (dv: K8sResourceKind) =>


atiratree · 2020-07-29T17:54:16Z

frontend/packages/kubevirt-plugin/src/utils/pending-changes.ts

+import { history } from '@console/internal/components/utils/router';
+import { VMKind, VMIKind } from '../types';
+
+const getTabURL = (vm: VMKind, tabName: VMTabURLEnum) =>


better to have this func in ./url ?

atiratree · 2020-07-29T17:56:40Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/disk-wrapper.ts

@@ -71,4 +71,31 @@ export class DiskWrapper extends ObjectWithTypePropertyWrapper<
        };
    }
  }
+
+  isDisksEqual = (otherDisk: V1Disk, omitRuntimeData?: boolean): boolean => {


the name suggests there are multiple disks. Can we use either isDiskEqual or isEqual

atiratree · 2020-07-29T17:56:49Z

frontend/packages/kubevirt-plugin/src/k8s/wrapper/vm/volume-wrapper.ts

@@ -143,4 +144,31 @@ export class VolumeWrapper extends ObjectWithTypePropertyWrapper<
        return null;
    }
  }
+
+  isVolumesEqual = (otherVolume: V1Volume, omitRuntimeData?: boolean) => {


atiratree · 2020-07-29T17:58:08Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-environment/selectors.ts

+    .getServiceAccounts()
+    .find((vol) => vol.serviceAccount.serviceAccountName === sourceName);
+
+const getVolumeBySource = (sourceName: string, vmWrapper: VMWrapper) =>


atiratree · 2020-07-29T18:01:31Z

frontend/packages/kubevirt-plugin/src/utils/pending-changes.ts

+
+export const hasPendingChanges = (vm: VMKind, vmi: VMIKind): boolean => {
+  const pendingChanges = !!vmi && getPendingChanges(new VMWrapper(vm), new VMIWrapper(vmi));
+  return Object.keys(pendingChanges).reduce(


it will crash if pendingChanges get null

atiratree · 2020-07-29T18:13:14Z

frontend/packages/kubevirt-plugin/src/components/vm-nics/vm-nics.tsx

                  }).result,
                )
              }
-              isDisabled={isLocked || isVMRunningOrExpectedRunning(asVM(vmLikeEntity))}
+              isDisabled={isLocked}


we should allow editing for the nics/disks as well if we allow creating them

@suomiy we cannot allow editing / deleting disks and nics at the moment, since it could result unexpected behavior.
For example: adding a disk -> add it to the boot order -> delete the disk. result an invalid boot order.
I believe there are other edge cases like this.

IMO, we should have this functionality, but it needs to be checked and tested and not added at the last moment. I would like to avoid making the PR unstable.

it should be the same and we should be detecting all relevant changes since it goes all through yaml. Anyway I don't mind adding this later

atiratree · 2020-07-29T18:13:37Z

frontend/packages/kubevirt-plugin/src/components/vm-status/vm-status.tsx

+      key={`pcViewDetailsBtn-${getName(vm)}`}
+      variant={ButtonVariant.plain}
+      onMouseUp={() =>
+        history.push(`/ns/${getNamespace(vm)}/virtualmachines/${getName(vm)}/details`)


also there are some other places in the code where this could be used

atiratree · 2020-07-30T08:00:52Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-environment/selectors.ts

+      return false;
+    }
+
+    switch (volType) {


this is the exact logic of getVolumeReferencedObject. So you can do volWrapper.getVolumeReferencedObject()?.name === sourceName instead

and isEnvType is ensuring you are having the correct type

atiratree · 2020-07-30T08:01:11Z

frontend/packages/kubevirt-plugin/src/components/vms/vm-environment/selectors.ts

+    const volWrapper = new VolumeWrapper(vol);
+    const volType = volWrapper.getType();
+
+    if (!volType.isEnvType()) {


Suggested change

if (!volType.isEnvType()) {

if (!volType?.isEnvType()) {

NPE

atiratree · 2020-07-30T09:48:26Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.tsx

+    <PendingChangesAlert isWarning>
+      {PENDING_CHANGES_WARNING_MESSAGE}
+      <List className="kv-warning--pf-c-list">
+        {Object.keys(pendingChangesByTab).map(


Suggested change

{Object.keys(pendingChangesByTab).map(

{Object.keys(getPendingChangesByTab(pendingChanges)).map(

IMO better to move here, since we do not need the variable before early return

I'm using pendingChangesByTab later too.
moving the variable creation after the early return.

atiratree · 2020-07-30T09:50:45Z

frontend/packages/kubevirt-plugin/src/components/vms/pending-changes-warning.tsx

+  const arePendingChanges = hasPendingChanges(vm, vmi, pendingChanges);
+  const pendingChangesByTab = getPendingChangesByTab(pendingChanges);
+
+  if (Object.keys(pendingChanges).length === 0 || !arePendingChanges) {


better to use lodash _.isEmpty here since it also covers null and is easier to read

Present a warning when the user make changes while the VM is running Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com> CNV-5024# Please enter the commit message for your changes. Lines starting

atiratree · 2020-07-30T10:25:44Z

/lgtm

rawagner · 2020-07-30T11:19:27Z

/approve

openshift-ci-robot · 2020-07-30T11:19:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irosenzw, rawagner, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/console-shared/OWNERS~~ [rawagner]
~~frontend/packages/kubevirt-plugin/OWNERS~~ [rawagner,suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot requested review from rawagner and atiratree May 31, 2020 15:22

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label May 31, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch from ed6b730 to 95ab4a2 Compare June 1, 2020 07:40

atiratree suggested changes Jun 1, 2020

View reviewed changes

irosenzw force-pushed the warn-for-changes-to-be-made branch from 95ab4a2 to 2480e2d Compare June 2, 2020 07:42

atiratree reviewed Jun 2, 2020

View reviewed changes

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx Show resolved Hide resolved

irosenzw changed the title ~~CNV-5024: Inform for pending changes in VM details view~~ [WIP] CNV-5024: Inform for pending changes in VM details view Jun 3, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch from 2480e2d to 9d97653 Compare June 15, 2020 13:10

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 15, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch from 9d97653 to 9846aa0 Compare June 21, 2020 14:54

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch 5 times, most recently from dad5725 to 1c0a0db Compare June 23, 2020 12:14

irosenzw force-pushed the warn-for-changes-to-be-made branch 3 times, most recently from adb6c4f to b84f199 Compare June 30, 2020 12:45

irosenzw force-pushed the warn-for-changes-to-be-made branch from b84f199 to f76ca1d Compare July 8, 2020 07:12

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2020

irosenzw changed the title ~~[WIP] CNV-5024: Inform for pending changes in VM details view~~ CNV-5024: Inform for pending changes in VM details view Jul 8, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2020

atiratree suggested changes Jul 22, 2020

View reviewed changes

irosenzw force-pushed the warn-for-changes-to-be-made branch from fc1be5b to 9feaa51 Compare July 23, 2020 20:02

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch from 9feaa51 to 5265505 Compare July 27, 2020 11:46

openshift-ci-robot added component/shared Related to console-shared and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 27, 2020

irosenzw force-pushed the warn-for-changes-to-be-made branch 6 times, most recently from 7895f7e to ff2bc6c Compare July 28, 2020 12:49

atiratree suggested changes Jul 28, 2020

View reviewed changes

irosenzw force-pushed the warn-for-changes-to-be-made branch from ff2bc6c to 4c2c611 Compare July 29, 2020 11:10

atiratree suggested changes Jul 29, 2020

View reviewed changes

irosenzw force-pushed the warn-for-changes-to-be-made branch from 4c2c611 to 12df37f Compare July 30, 2020 07:02

atiratree suggested changes Jul 30, 2020

View reviewed changes

irosenzw force-pushed the warn-for-changes-to-be-made branch from 12df37f to c864ca4 Compare July 30, 2020 09:23

atiratree reviewed Jul 30, 2020

View reviewed changes

CNV-5024: Inform for pending changes in VM's configuration

ad24404

Present a warning when the user make changes while the VM is running Signed-off-by: Ido Rosenzwig <irosenzw@redhat.com> CNV-5024# Please enter the commit message for your changes. Lines starting

irosenzw force-pushed the warn-for-changes-to-be-made branch from c864ca4 to ad24404 Compare July 30, 2020 10:02

openshift-ci-robot assigned atiratree Jul 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2020

openshift-merge-robot merged commit 616b108 into openshift:master Jul 30, 2020

spadgett added this to the v4.6 milestone Jul 30, 2020

		@@ -0,0 +1,181 @@
		import { VMWrapper } from '../../k8s/wrapper/vm/vm-wrapper';

	areVolumesEqual = (volume: V1Volume, omitRuntimeData?: boolean) => {
	areVolumesEqual = (otherVolume: V1Volume, omitRuntimeData?: boolean) => {


		const thisResource = this.asResource();

		if (!omitRuntimeData) {

		@@ -41,6 +43,14 @@ export class VMIWrapper extends K8sResourceWrapper<VMIKind, VMIWrapper> implemen

		getVolumes = (defaultValue = []) => getVMIVolumes(this.data, defaultValue);

		getVolumeByName = (volName: string): V1Volume =>

		@@ -60,20 +60,30 @@ export class VMWrapper extends K8sResourceWrapper<VMKind, VMWrapper> implements

		getVolumes = (defaultValue = []) => getVolumes(this.data, defaultValue);

		getVolumeByName = (volName: string): V1Volume =>

	{Object.keys(pendingChangesByTab).map(
	{Object.keys(getPendingChangesByTab(pendingChanges)).map(

CNV-5024: Inform for pending changes in VM details view #5633

CNV-5024: Inform for pending changes in VM details view #5633

Conversation

irosenzw commented May 31, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Jun 2, 2020

matthewcarleton commented Jun 8, 2020

irosenzw commented Jun 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

irosenzw Jul 22, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Jul 30, 2020

rawagner commented Jul 30, 2020

openshift-ci-robot commented Jul 30, 2020

irosenzw Jul 22, 2020 •

edited