Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete application error if ImageStream is not present for a resource #5638

Merged
merged 1 commit into from Jun 18, 2020

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Jun 1, 2020

fixes: https://issues.redhat.com/browse/ODC-3731

Analysis/root cause: For resources created through the internal image registry. ImageStream is not created which cause the error while deleting an application

Solution: Add a check for ImageStream before deleting all the related resources in an application

Screenshot:
Peek 2020-06-01 18-14

@@ -482,7 +492,7 @@ export const cleanUpWorkload = (
case DeploymentConfigModel.kind:
deleteRequest(modelFor(resource.kind), resource);
batchDeleteRequests(deleteModels, resource);
deleteRequest(ImageStreamModel, resource); // delete imageStream
// deleteRequest(ImageStreamModel, resource); // delete imageStream
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we remove this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this, will remove it

@invincibleJai
Copy link
Member

Verified, able to delete workloads and knative service created with internal image registry.

@andrewballantyne
Copy link
Contributor

/assign @invincibleJai

Mind giving this another review @invincibleJai ?

@invincibleJai
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2020
@karthikjeeyar
Copy link
Contributor

Verified locally, Works as expected
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c298036 into openshift:master Jun 18, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants