-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix delete application error if ImageStream is not present for a resource #5638
fix delete application error if ImageStream is not present for a resource #5638
Conversation
@@ -482,7 +492,7 @@ export const cleanUpWorkload = ( | |||
case DeploymentConfigModel.kind: | |||
deleteRequest(modelFor(resource.kind), resource); | |||
batchDeleteRequests(deleteModels, resource); | |||
deleteRequest(ImageStreamModel, resource); // delete imageStream | |||
// deleteRequest(ImageStreamModel, resource); // delete imageStream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this, will remove it
Verified, able to delete workloads and knative service created with internal image registry. |
…urce remove comments
62b7be9
to
9e6e02a
Compare
/assign @invincibleJai Mind giving this another review @invincibleJai ? |
/approve |
Verified locally, Works as expected |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, karthikjeeyar, sahil143 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: https://issues.redhat.com/browse/ODC-3731
Analysis/root cause: For resources created through the internal image registry. ImageStream is not created which cause the error while deleting an application
Solution: Add a check for ImageStream before deleting all the related resources in an application
Screenshot: