fix(plr-viz): Remove log links fr Idle/cancelled tasks #5649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewballantyne
suggested changes
Jun 3, 2020
...ole/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualizationTask.tsx
Outdated
Show resolved
Hide resolved
…page-tabs/pipeline-details/PipelineVisualizationTask.tsx Co-authored-by: Andrew Ballantyne <8126518+andrewballantyne@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, andrewballantyne The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-2415
Additionally will fix issue mentioned in
https://issues.redhat.com/browse/ODC-2509
Analysis / Root cause:
Clicking on a pending task bubble in the PLR brings you to a Log page with an odd message
Solution Description:
Changed cusor to default for Task Bubbles(as it shows a selection cursor earlier) as per UX feedback
Changed cursor to pointer for Logs with Links.
Removed linking logic and only Tasks is Completed, Running and failed status would have a link now.
Changed negation logic and instead doing positive check such that visualization issue
https://issues.redhat.com/browse/ODC-2509 will be fixed.
Screenshot
Browser conformation
Chrome 73