Create multi tab list component and using that render various pipeline lists #5700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyanshiGupta
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
divyanshiGupta
force-pushed
the
pipeline-lists
branch
from
1ff3d31
to
8a57d38
Compare
divyanshiGupta
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
divyanshiGupta
force-pushed
the
pipeline-lists
branch
5 times, most recently
from
ee8d9af
to
5ff3e1b
Compare
andrewballantyne
suggested changes
Jun 11, 2020
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.scss
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines-lists/PipelinesListsPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelines-lists/PipelinesListsPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelineruns/PipelineRunsResourceList.tsx
Outdated
Show resolved
Hide resolved
...ckages/dev-console/src/components/pipeline-resources/list-page/PipelineResourcesListPage.tsx
Show resolved
Hide resolved
divyanshiGupta
force-pushed
the
pipeline-lists
branch
2 times, most recently
from
b3524e7
to
a2f30a5
Compare
andrewballantyne
suggested changes
Jun 16, 2020
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/multi-tab-list/MultiTabListPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/src/components/pipelineruns/PipelineRunsResourceList.tsx
Outdated
Show resolved
Hide resolved
divyanshiGupta
force-pushed
the
pipeline-lists
branch
from
c98510e
to
bdba469
Compare
|
/assign @christianvogt Because of the logic change in the list page, we'll need a review from Christian. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, christianvogt, divyanshiGupta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://issues.redhat.com/browse/ODC-4006
Additional Sub-tasks: https://issues.redhat.com/browse/ODC-4142, https://issues.redhat.com/browse/ODC-4143
This PR adds a new multi tab list page which is being used to render various pipeline lists. This PR also updates pipelines nav.
Note-
Will be adding PipelineResources filters in the upcoming PR for story ODC-4007 which is about adding the pages.
Screenshot:
