Add tasks and triggers pages in console #5744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
component/core
divyanshiGupta
force-pushed
the
admin-pipelines
branch
3 times, most recently
from
a2156d7
to
41a4d11
Compare
andrewballantyne
approved these changes
Jun 18, 2020
| @@ -46,3 +46,15 @@ export const pipelineRunStatusFilter = (phases, pipeline) => { | |||
| const status = pipelineRunFilterReducer(pipeline); | |||
| return phases.selected.has(status) || !_.includes(phases.all, status); | |||
| }; | |||
|
|
|||
| export const pipelineResourceFilterReducer = (pipelineResource): string => { | |||
There was a problem hiding this comment.
Was going to suggest types here, but there is a circular dependency between these files 🤦 Okay. Part of the tech debt.
openshift-ci-robot
added
the
do-not-merge/hold
divyanshiGupta
force-pushed
the
admin-pipelines
branch
from
41a4d11
to
587304b
Compare
openshift-ci-robot
added
the
approved
divyanshiGupta
force-pushed
the
admin-pipelines
branch
from
587304b
to
4df7027
Compare
|
/lgtm |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, divyanshiGupta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Story - https://issues.redhat.com/browse/ODC-4007
In this PR I have added tasks and triggers pages to pipelines nav in console, created custom task-runs list page and added filters to pipeline-resources list page.
Screenshot:
Note -
This PR has a dependency on #5700