Alert when stopping a vm with logged in users #5733

yaacov · 2020-06-15T13:50:23Z

Alert when stoping a vm with logged in users

Desing: http://openshift.github.io/openshift-origin-design/designs/virtualization/4.x/expose-guest-data/expose%20guest%20data.html#details-tab

separate different vm delete modals
add a special delete modal for vmi
add special modals for stop / restart
add users logged in warning to delete/stop/restart modals

Screenshot:

yaacov · 2020-06-15T13:50:44Z

@pcbailey please review

pcbailey

Just a few minor comments for the moment.

pcbailey · 2020-06-17T12:35:03Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-modal.tsx

  };

  return (
    <form onSubmit={submit} className="modal-content">
      <ModalTitle>
        <YellowExclamationTriangleIcon className="co-icon-space-r" /> Delete{' '}
-        {isTemplate(vmLikeEntity) ? 'Virtual Machine Template' : entityModel.label}?
+        {VirtualMachineModel.label}?


Now that the ternary operator is removed, I think this can be written more cleanly as a template literal.

pcbailey · 2020-06-17T12:36:29Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-modal.tsx

-        Are you sure you want to delete{' '}
-        <strong className="co-break-word">{getName(vmLikeEntity)}</strong> in namespace{' '}
-        <strong>{getNamespace(vmLikeEntity)}</strong> ?
+        Are you sure you want to delete <strong className="co-break-word">{name}</strong> in


This looks much cleaner. =)

pcbailey · 2020-06-17T12:39:23Z

...kages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-template-modal.tsx

+    <form onSubmit={submit} className="modal-content">
+      <ModalTitle>
+        <YellowExclamationTriangleIcon className="co-icon-space-r" /> Delete Virtual Machine
+        Template ?


Should there be a space before all of the question marks here? I see several like this.

pcbailey · 2020-06-17T12:47:10Z

...tend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vmi-modal.tsx

+import { VMIKind } from '../../../types';
+import { VirtualMachineInstanceModel } from '../../../models';
+
+const redirectFn = (vmi: VMIKind) => {


I feel like this should be made more general and shared among all the different modals.

moved to a utils file

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-modal.tsx

...kages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-template-modal.tsx

atiratree · 2020-06-17T13:35:35Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-modal.tsx

-        deleteOwnedVolumeResources: deleteDisks,
-      });
-    }
+    const promise = deleteVM(vmUpToDate, {


+1 for splitting the functionality, makes it more readable

atiratree · 2020-06-17T13:36:05Z

...kages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vm-template-modal.tsx

+import { useUpToDateVMLikeEntity } from '../../../hooks/use-vm-like-entity';
+import { deleteVMTemplate } from '../../../k8s/requests/vmtemplate/actions';
+
+const redirectFn = (vmLikeEntity: TemplateKind) => {


How about something like redirectAfterDeletion?

atiratree · 2020-06-17T13:45:00Z

...tend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vmi-modal.tsx

+  }
+};
+
+export const DeleteVMIModal = withHandlePromise((props: DeleteVMIProps) => {


Should we also ask for disk removal in standalone VMIs which do not belong to any VM resource?

atiratree · 2020-06-17T13:45:47Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/vmi-users-alert.tsx

+
+  const name = getName(vmi);
+  const namespace = getNamespace(vmi);
+  const alertHref = `/k8s/ns/${namespace}/virtualmachines/${name}/details#logged-in-users`;


what about standalone VMIs?

Thanks !!! wow, no I remember why I took it out to be a separate modal !

atiratree · 2020-06-17T13:53:07Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/vmi-users-alert.tsx

+      </>
+    );
+  } else if (userListLength > 1) {
+    alertBody = (


this feels like it should be parametrized

Agreed. I think this can be done in one Button component using pluralize. I don't think it will hurt anything if we use a numeral 1 instead of "One".

+2 :-) fixing

atiratree · 2020-06-18T08:53:07Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/utils.ts

+import { getName, getNamespace } from '@console/shared/src/selectors/common';
+import { VMILikeEntityKind } from 'packages/kubevirt-plugin/src/types/vmLike';
+
+export const redirectAfterVMDeletion = (vmi: VMILikeEntityKind) => {


can we use this one for the template as well? And parametrize the /virtualization part? I guess better name could be redirectToList

yes, made it one method, much nicer now

atiratree · 2020-06-18T08:54:39Z

...tend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vmi-modal.tsx

+    <form onSubmit={submit} className="modal-content">
+      <ModalTitle>
+        <YellowExclamationTriangleIcon className="co-icon-space-r" /> Delete Virtual Machine
+        Instanse ?


Suggested change

Instanse ?

Instance ?

yaacov · 2020-06-22T15:55:07Z

@suomiy @pcbailey addressed all comments, please re-review

pcbailey · 2020-06-23T00:13:19Z

...tend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/delete-vmi-modal.tsx

+        namespace <strong>{namespace}</strong>?
+        {numOfAllResources > 0 && (
+          <p>
+            The following resources will be deleted along with this virtual machine instance.


If I understand this correctly, this message is wrong. It looks like this is displaying the number of disks and giving a single checkbox to indicate consent to delete them or not. This message implies that there should be a list containing each of the individual resources with their own checkbox, where the user can pick which resources to delete and which to leave.

pcbailey · 2020-06-23T00:13:53Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/utils.ts

+import { getName, getNamespace } from '@console/shared/src/selectors/common';
+import { VMGenericLikeEntityKind } from 'packages/kubevirt-plugin/src/types/vmLike';
+
+export const redirectToList = (vmi: VMGenericLikeEntityKind, tab?: 'templates' | '' | null) => {


pcbailey · 2020-06-23T00:15:35Z

frontend/packages/kubevirt-plugin/src/components/modals/menu-actions-modals/vmi-users-alert.tsx

+      <Button variant="link" isInline onClick={onLinkClick}>
+        {pluralize(userListLength, 'User')}
+      </Button>{' '}
+      currently logged in to this VM. Proceeding with this operation may cause logged in users data


I would change the last sentence to "Proceeding with this operation may cause logged in users to lose data."

pcbailey · 2020-06-23T00:17:59Z

I'm going to approve this. We can fix these two messages in a follow-up.
/lgtm

openshift-ci-robot · 2020-06-23T00:18:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [yaacov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/kubevirt Related to kubevirt-plugin labels Jun 15, 2020

openshift-ci-robot requested review from mareklibra and vojtechszocs June 15, 2020 13:50

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2020

yaacov force-pushed the alert-stop-vm-with-users branch 5 times, most recently from 30b7ab7 to 176ba44 Compare June 17, 2020 12:25

yaacov changed the title ~~[WIP] Alert when stoping a vm with logged in users~~ Alert when stoping a vm with logged in users Jun 17, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2020

yaacov changed the title ~~Alert when stoping a vm with logged in users~~ Alert when stopping a vm with logged in users Jun 17, 2020

pcbailey reviewed Jun 17, 2020

View reviewed changes

yaacov force-pushed the alert-stop-vm-with-users branch 3 times, most recently from bf65f18 to 667789b Compare June 17, 2020 13:47

atiratree reviewed Jun 17, 2020

View reviewed changes

yaacov force-pushed the alert-stop-vm-with-users branch 5 times, most recently from c81de9f to b8ffdb6 Compare June 17, 2020 14:58

atiratree reviewed Jun 18, 2020

View reviewed changes

yaacov force-pushed the alert-stop-vm-with-users branch from b8ffdb6 to 20cc086 Compare June 18, 2020 10:13

atiratree mentioned this pull request Jun 18, 2020

kubevirt: add hash anchors to VM / VM tempplate details #5777

Merged

yaacov force-pushed the alert-stop-vm-with-users branch from 20cc086 to 0e80679 Compare June 22, 2020 15:53

yaacov force-pushed the alert-stop-vm-with-users branch from 0e80679 to 96ba940 Compare June 22, 2020 16:04

Alert when stoping a vm with logged in users

b3e78e7

yaacov force-pushed the alert-stop-vm-with-users branch from 96ba940 to b3e78e7 Compare June 22, 2020 16:17

pcbailey reviewed Jun 23, 2020

View reviewed changes

openshift-ci-robot assigned pcbailey Jun 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2020

openshift-merge-robot merged commit 2a7bbf4 into openshift:master Jun 23, 2020

yaacov mentioned this pull request Jun 23, 2020

kubevirt: Update text in delete vmi users alert #5804

Merged

spadgett added this to the v4.6 milestone Jun 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Alert when stopping a vm with logged in users #5733

Alert when stopping a vm with logged in users #5733

yaacov commented Jun 15, 2020 •

edited

yaacov commented Jun 15, 2020

pcbailey left a comment

pcbailey Jun 17, 2020

yaacov Jun 17, 2020

pcbailey Jun 17, 2020

pcbailey Jun 17, 2020

yaacov Jun 17, 2020

pcbailey Jun 17, 2020

yaacov Jun 17, 2020

atiratree Jun 17, 2020

atiratree Jun 17, 2020

pcbailey Jun 17, 2020

yaacov Jun 17, 2020

atiratree Jun 17, 2020

yaacov Jun 22, 2020

atiratree Jun 17, 2020

yaacov Jun 17, 2020

atiratree Jun 17, 2020

pcbailey Jun 17, 2020

yaacov Jun 17, 2020

yaacov Jun 17, 2020

atiratree Jun 18, 2020

yaacov Jun 18, 2020

atiratree Jun 18, 2020

yaacov Jun 18, 2020

yaacov commented Jun 22, 2020

pcbailey Jun 23, 2020

pcbailey Jun 23, 2020

pcbailey Jun 23, 2020

pcbailey commented Jun 23, 2020

openshift-ci-robot commented Jun 23, 2020

Alert when stopping a vm with logged in users #5733

Alert when stopping a vm with logged in users #5733

Conversation

yaacov commented Jun 15, 2020 • edited

yaacov commented Jun 15, 2020

pcbailey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yaacov commented Jun 22, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pcbailey commented Jun 23, 2020

openshift-ci-robot commented Jun 23, 2020

yaacov commented Jun 15, 2020 •

edited