-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds datamodel for channel and update visualisation #5803
Merged
openshift-merge-robot
merged 2 commits into
openshift:master
from
invincibleJai:feat-channel-dm
Jun 26, 2020
Merged
adds datamodel for channel and update visualisation #5803
openshift-merge-robot
merged 2 commits into
openshift:master
from
invincibleJai:feat-channel-dm
Jun 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
component/dev-console
Related to dev-console
labels
Jun 23, 2020
openshift-ci-robot
added
component/knative
Related to knative-plugin
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Jun 23, 2020
invincibleJai
force-pushed
the
feat-channel-dm
branch
5 times, most recently
from
June 23, 2020 12:11
b642982
to
e6a0299
Compare
invincibleJai
force-pushed
the
feat-channel-dm
branch
7 times, most recently
from
June 24, 2020 14:59
4c40bcf
to
798025e
Compare
invincibleJai
changed the title
[WIP] adds datamodel for channel and update visualisation
adds datamodel for channel and update visualisation
Jun 24, 2020
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Jun 24, 2020
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
feat-channel-dm
branch
4 times, most recently
from
June 25, 2020 08:17
3f29b53
to
4138aee
Compare
Tested locally. Works great. |
jeff-phillips-18
approved these changes
Jun 25, 2020
invincibleJai
force-pushed
the
feat-channel-dm
branch
from
June 25, 2020 12:00
4138aee
to
786eec3
Compare
invincibleJai
force-pushed
the
feat-channel-dm
branch
3 times, most recently
from
June 26, 2020 08:42
b955ec9
to
7c686d9
Compare
invincibleJai
force-pushed
the
feat-channel-dm
branch
from
June 26, 2020 09:12
7c686d9
to
045ff25
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
component/dev-console
Related to dev-console
component/knative
Related to knative-plugin
lgtm
Indicates that a PR is ready to be merged.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Analysis / Root cause:
In topology we don't visualise Channels / Subscription associated relation with Sources and kn service
Solution Description:
Screen shots / Gifs for design review:
Sidebar for Channel
Sidebar for Subscription connector
Sidebar for eventSource while sinking to channel
gif showing some of gestures and action menu
@openshift/team-devconsole-ux
Unit test coverage report:
Test setup:
Browser conformance: