Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds datamodel for channel and update visualisation #5803

Merged
merged 2 commits into from Jun 26, 2020
Merged

adds datamodel for channel and update visualisation #5803

merged 2 commits into from Jun 26, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Jun 23, 2020 •
edited

Fixes:

Analysis / Root cause:
In topology we don't visualise Channels / Subscription associated relation with Sources and kn service

Solution Description:

  • Fetch Channels CRDs based on label and and form Datamodel required for visualising Channel / Subscription associated relation
  • Extending Shape for Channel
  • Extending connector for Subscription
  • Show sidebar for channel
  • Show sidebar for Subscription connector
  • Update sidebar for EventSources
  • Action menus for Channel Node/Subscription Edge - Move Subscription apart from custom one's
  • Gestures for for eventSource Connector can be dropped to Channel as well
  • Gestures for for Subscription Connector can be dropped to Other kn Svc as well

Screen shots / Gifs for design review:

  • Sidebar for Channel
    image

  • Sidebar for Subscription connector
    image

  • Sidebar for eventSource while sinking to channel
    image

  • gif showing some of gestures and action menu

Jun-26-2020 09-46-13

@openshift/team-devconsole-ux

Unit test coverage report:
image

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/dev-console Related to dev-console labels Jun 23, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 23, 2020
@invincibleJai invincibleJai force-pushed the feat-channel-dm branch 5 times, most recently from b642982 to e6a0299 Compare June 23, 2020 12:11
@invincibleJai invincibleJai force-pushed the feat-channel-dm branch 7 times, most recently from 4c40bcf to 798025e Compare June 24, 2020 14:59
@invincibleJai invincibleJai changed the title [WIP] adds datamodel for channel and update visualisation adds datamodel for channel and update visualisation Jun 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2020
karthikjeeyar
karthikjeeyar reviewed Jun 24, 2020
View reviewed changes
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/components/nodes/EventingPubSubNode.tsx Outdated Show resolved Hide resolved
frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
@invincibleJai invincibleJai force-pushed the feat-channel-dm branch 4 times, most recently from 3f29b53 to 4138aee Compare June 25, 2020 08:17
@jeff-phillips-18
Copy link
Member

Tested locally. Works great.

@invincibleJai invincibleJai force-pushed the feat-channel-dm branch 3 times, most recently from b955ec9 to 7c686d9 Compare June 26, 2020 08:42
@jeff-phillips-18
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7ce65f4 into openshift:master Jun 26, 2020
@spadgett spadgett added this to the v4.6 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@abhi-kn abhi-kn Awaiting requested review from abhi-kn

Assignees

@jeff-phillips-18 jeff-phillips-18

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@invincibleJai @jeff-phillips-18 @openshift-ci-robot @karthikjeeyar @spadgett @openshift-merge-robot