adds capability for sources to sink to channel and broker along with ksvc #5849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
component/knative
invincibleJai
force-pushed
the
fix-sink-source
branch
3 times, most recently
from
ddb1e68
to
3578384
Compare
invincibleJai
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
invincibleJai
force-pushed
the
fix-sink-source
branch
from
3578384
to
c52eb5f
Compare
frontend/packages/knative-plugin/src/components/add/EventSourceAlert.tsx
Outdated
Show resolved
Hide resolved
invincibleJai
force-pushed
the
fix-sink-source
branch
2 times, most recently
from
ddf8889
to
0bb1f5d
Compare
invincibleJai
force-pushed
the
fix-sink-source
branch
from
0bb1f5d
to
60dff46
Compare
|
verfied locally, looks good to me |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-4166
Analysis / Root cause:
User is unable to sink a source to broker and channels along with ksvc
Solution Description:
nsnone of the above resources is presentScreen shots / Gifs for design review:
Ability to sink to Channel/Broker/ksvc
Visualisation post sink to channel
Error message if none of Channel/Broker/ksvc exists in a namespace
Note: Discuss with UXD as IMO this specific error message will not be needed once sink uri support comes in
@openshift/team-devconsole-ux @rachael-phillips
Test Coverage
Browser conformance: