Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overflow:hidden so that yaml help tool tips aren't clipped. #5912

Merged
merged 1 commit into from Jul 8, 2020
Merged

Remove overflow:hidden so that yaml help tool tips aren't clipped. #5912

merged 1 commit into from Jul 8, 2020

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Jul 7, 2020

@sg00dwin
Copy link
Member Author

sg00dwin commented Jul 8, 2020

/retest

rhamilto
rhamilto reviewed Jul 8, 2020
View reviewed changes
frontend/packages/console-shared/src/components/editor/YAMLEditor.scss
@@ -1,13 +1,11 @@
.ocs-yaml-editor {
&__root {
flex: 1;
overflow: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitkrai03 do you recall why the overflow: hidden was present?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was present to make sure that the YAML editor would adapt properly for any screen size but in retrospect I guess it's not necessary to have overflow: hidden because the monaco editor handles the overflow of text in the editor wrapper itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it just now with overflow: hidden removed and it's working fine. Can't think of a scenario where it seems to break anything.

spadgett
spadgett approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sg00dwin, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@rohitkrai03
Copy link
Contributor

/hold

It breaks the YAML editor on Safari.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@rohitkrai03
Copy link
Contributor

/hold cancel

Edit - YAML Editor layout seems to be already broken on Safari without the changes from this PR. We should create a new issue to track that. @christianvogt can add more details.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2020
@openshift-merge-robot openshift-merge-robot merged commit 36a70de into openshift:master Jul 8, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 9, 2020
@sg00dwin sg00dwin deleted the yaml-help-text-clipped branch July 16, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 left review comments

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sg00dwin @openshift-ci-robot @rohitkrai03 @rhamilto @spadgett @openshift-merge-robot