Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overflow:hidden so that yaml help tool tips aren't clipped. #5912

Merged
merged 1 commit into from Jul 8, 2020
Merged

Remove overflow:hidden so that yaml help tool tips aren't clipped. #5912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions frontend/packages/console-shared/src/components/editor/YAMLEditor.scss
View file
Open in desktop
@@ -1,13 +1,11 @@
.ocs-yaml-editor {
&__root {
flex: 1;
overflow: hidden;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rohitkrai03 do you recall why the overflow: hidden was present?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was present to make sure that the YAML editor would adapt properly for any screen size but in retrospect I guess it's not necessary to have overflow: hidden because the monaco editor handles the overflow of text in the editor wrapper itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it just now with overflow: hidden removed and it's working fine. Can't think of a scenario where it seems to break anything.

position: relative;
}

&__wrapper {
position: absolute;
overflow: hidden;
top: 0;
right: 0;
left: 0;
Expand Down