-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Snapshot related components from OCS Plugin #5968
Remove Snapshot related components from OCS Plugin #5968
Conversation
@bipuladh please remove following files as well
|
@bipuladh please do following changes as well.
|
4245f5e
to
89f68bf
Compare
89f68bf
to
7096d69
Compare
/hold |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove VolumeSnapshotModel
in models.ts
diff --git a/frontend/packages/ceph-storage-plugin/src/models.ts b/frontend/packages/ceph-storage-plugin/src/models.ts
index 172262560..4612aa478 100644
--- a/frontend/packages/ceph-storage-plugin/src/models.ts
+++ b/frontend/packages/ceph-storage-plugin/src/models.ts
@@ -25,16 +25,3 @@ export const OCSServiceModel: K8sKind = {
id: 'ocscluster',
crd: true,
};
-
-export const VolumeSnapshotModel: K8sKind = {
- label: 'Volume Snapshot',
- apiVersion: 'snapshot.storage.k8s.io/v1beta1',
- apiGroup: '',
- plural: 'volumesnapshots',
- abbr: 'VS',
- namespaced: true,
- kind: 'VolumeSnapshot',
- id: 'volumesnapshot',
- labelPlural: 'Volume Snapshots',
- crd: true,
-};
7096d69
to
c4fe426
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a2batic, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.