Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot tab for PVC page #6006

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Snapshot tab for PVC page #6006

merged 1 commit into from
Jul 27, 2020

Conversation

cloudbehl
Copy link
Contributor

@cloudbehl cloudbehl commented Jul 16, 2020 •
edited
Loading

Screenshot 2020-07-17 at 4 48 55 PM

Signed-off-by: Ankush Behl cloudbehl@gmail.com

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 16, 2020
bipuladh
bipuladh reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@bipuladh bipuladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the PVC column hidden from the list page when we are showing from the tab. It does not make sense to show this information.

@cloudbehl cloudbehl force-pushed the pvc-snapshot branch 2 times, most recently from ab70afe to d960c59 Compare July 17, 2020 11:26
@cloudbehl
Copy link
Contributor Author

@bipuladh @a2batic @rawagner can you review this PR?

bipuladh
bipuladh reviewed Jul 21, 2020
View reviewed changes
frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx Outdated
};

type VolumeSnapshotPVCPage = {
obj: K8sResourceKind;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
obj: K8sResourceKind;
obj: PersistentVolumeClaimKind;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PersistentVolumeClaimKind is not present now as it will be introduced in this PR: https://github.com/openshift/console/pull/5893/files#diff-26cde32482ccee5968a1f4d2d69ffe03R1018

I'll send a followup to address it.

frontend/packages/console-app/src/components/volume-snapshot/volume-snapshot.tsx Outdated Show resolved Hide resolved
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2020
@rawagner
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@cloudbehl
Copy link
Contributor Author

/hold needs rebase

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@cloudbehl
Snapshot tab for PVC page
3e71947 
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@cloudbehl
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2020
@bipuladh
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 91afc03 into openshift:master Jul 27, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bipuladh bipuladh bipuladh left review comments

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@bipuladh bipuladh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.
7 participants
@cloudbehl @bipuladh @rawagner @openshift-bot @openshift-ci-robot @spadgett @openshift-merge-robot