Add capability to collapse all grouping in topology view #6009
Conversation
openshift-ci-robot
added
the
kind/feature
openshift-ci-robot
added
component/knative
jeff-phillips-18
force-pushed
the
collapse-groupings
branch
from
a5fc267
to
f724dc6
Compare
|
@beaumorley is there a design for this feature somewhere? I don't like how the filters become disabled. Furthermore there was discussion in the past about adding individual expand / collapses buttons on the nodes themselves which would conflict with what's shown here. Giving the user the ability to expand or collapse all and then modify from that state would make sense. |
| {expandFilters.length && ( | ||
| <div className="odc-topology-filter-dropdown__group"> | ||
| <span | ||
| key="expand-groups-switch" |
There was a problem hiding this comment.
key isn't required here.
| > | ||
| <span className="pf-c-select__menu-group-title">Expand</span> | ||
| <Switch | ||
| id="groups-collapse-switch" |
There was a problem hiding this comment.
Remove id attribute.
| filters: DisplayFilters, | ||
| groupsExpanded?: boolean, |
There was a problem hiding this comment.
Why isn't groupsExpanded just another type of display filter?
I was thinking that any display options could be handled the same way.
Then hide the usage behind a single hook which can fetch the expand display filter and only if the expand filter is true does it fetch the individual expand filter.
const isExpanded = useExpand(MY_DISPLAYFILTER);
f724dc6
to
0df4138
Compare
jeff-phillips-18
force-pushed
the
collapse-groupings
branch
from
0df4138
to
b5d2b16
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgliwa01, christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Fixes:
https://issues.redhat.com/browse/ODC-4316
Description:
As a developer, I want to view all my “Grouped Resources” (Application Groups, Helm Releases, Knative Services, Operator Backed Services)as collapsed groupings in the Topology Graph View
Screen shots / Gifs for design review:
Browser conformance:
cc @openshift/team-devconsole-ux @serenamarie125 @beaumorley @bgliwa01
/kind feature