Fix topology view updates on search and item select #6033
Conversation
openshift-ci-robot
added
the
kind/bug
|
@jeff-phillips-18 can we use react-router |
jeff-phillips-18
force-pushed
the
topology-update
branch
from
f7e622c
to
d337eca
Compare
| const selectId = queryParams.get('selectId'); | ||
| const selectTab = queryParams.get('selectTab'); |
There was a problem hiding this comment.
queryParams should be a dependency.
We should remove the comment // eslint-disable-next-line react-hooks/exhaustive-deps because that is an old comment and the dependencies have changed since.
| export const useQueryParams = () => { | ||
| return new URLSearchParams(useLocation().search); | ||
| }; |
There was a problem hiding this comment.
We want the result to be stable and only change when search has changed.
| export const useQueryParams = () => { | |
| return new URLSearchParams(useLocation().search); | |
| }; | |
| export const useQueryParams = () => { | |
| const search = useLocation().search; | |
| const queryParams = React.useMemo(() => new URLSearchParams(search), [search]); | |
| return queryParams; | |
| }; |
| kindsInFlight, | ||
| trafficData, | ||
| }) => { | ||
| const dataModelContext = React.useContext<ExtensibleModel>(ModelContext); | ||
| const [model, setModel] = React.useState<Model>(null); | ||
| const [loadError, setLoadError] = React.useState<string>(null); | ||
| const params = useParams(); |
There was a problem hiding this comment.
I think we are better off to pass in props than couple the component to URL params. Especially when the component is utility in nature.
| match: RMatch<{ | ||
| name?: string; | ||
| }>; |
There was a problem hiding this comment.
Can we just accept namespace here instead as to not couple this component to router or url.
jeff-phillips-18
force-pushed
the
topology-update
branch
from
d337eca
to
6d825e8
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
spadgett
added
the
kind/dependency-change
Fixes
https://issues.redhat.com/browse/ODC-4346
https://issues.redhat.com/browse/ODC-4355
Description
Topology graph view needs to update node renderings when the selections change and when the filter value changes. Add a watcher on the match parameter to re-render when it changes.
/kind bug