New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete HPA In-Context #6037
Delete HPA In-Context #6037
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
608bcfd
to
f302d61
Compare
f302d61
to
db51c09
Compare
/hold Waiting on dependant PR #6022. |
@andrewballantyne: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@andrewballantyne the remove action seems to only be available in topology. But not from the resource list or details pages. |
🤔 I suppose it probably shows the Add HPA action because it's in with the generics. I'll have to look into that. It was in context, but I guess that means more than Topology. |
See #6150 |
Built on #6022 - See the 2nd Commit
Fixes:
https://issues.redhat.com/browse/ODC-4270
Analysis / Root cause:
As a user, I want a way to delete an in-context HPA.
Solution Description:
Add a Kebab action and modal to support deleting the associated HPA on a workload.
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Browser conformance: