Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete HPA In-Context #6037

Closed

Conversation

andrewballantyne
Copy link
Contributor

@andrewballantyne andrewballantyne commented Jul 20, 2020

Built on #6022 - See the 2nd Commit

Fixes:
https://issues.redhat.com/browse/ODC-4270

Analysis / Root cause:
As a user, I want a way to delete an in-context HPA.

Solution Description:
Add a Kebab action and modal to support deleting the associated HPA on a workload.

Screen shots / Gifs for design review:

Screen Shot 2020-07-22 at 7 32 11 AM
Screen Shot 2020-07-22 at 7 32 19 AM

Unit test coverage report:

  doesHpaMatch checks if it aligns to a workload
    ✓ expect not to match when hpa does not target workload
    ✓ expect to match when hpa does target workload

------------------------------------------------------------|----------|----------|----------|----------|-------------------|
File                                                        |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
------------------------------------------------------------|----------|----------|----------|----------|-------------------|
  src/components/hpa/hpa-utils.ts                           |    97.26 |    90.63 |      100 |    96.83 |            92,100 |
------------------------------------------------------------|----------|----------|----------|----------|-------------------|

Test setup:

  • Add an HPA to a D/DC Workload that is in Topology
  • Use the Kebab action to delete

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrewballantyne
To complete the pull request process, please assign spadgett
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 20, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/shared Related to console-shared labels Jul 20, 2020
@andrewballantyne andrewballantyne changed the title Delete hpa [WIP] Delete hpa Jul 20, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2020
@andrewballantyne andrewballantyne mentioned this pull request Jul 20, 2020
4 tasks
@andrewballantyne andrewballantyne changed the title [WIP] Delete hpa Delete hpa Jul 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2020
@andrewballantyne
Copy link
Contributor Author

/hold

Waiting on dependant PR #6022.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2020
@andrewballantyne andrewballantyne changed the title Delete hpa Delete HPA In-Context Jul 22, 2020
@openshift-ci-robot
Copy link
Contributor

@andrewballantyne: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console db51c09 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@christianvogt
Copy link
Contributor

@andrewballantyne the remove action seems to only be available in topology. But not from the resource list or details pages.

@andrewballantyne
Copy link
Contributor Author

@andrewballantyne the remove action seems to only be available in topology. But not from the resource list or details pages.

🤔 I suppose it probably shows the Add HPA action because it's in with the generics. I'll have to look into that. It was in context, but I guess that means more than Topology.

@andrewballantyne
Copy link
Contributor Author

See #6150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants