HPA In-Context (Delete | Edit | Topology Sidebar)

[andrewballantyne]

Combined for easy reviewing. Former PRs: #6037, #6039, #6087

Fixes:
https://issues.redhat.com/browse/ODC-4270
https://issues.redhat.com/browse/ODC-4271
https://issues.redhat.com/browse/ODC-4272

Analysis / Root cause:

• As a user, I want a way to delete an in-context HPA.
• As a user, I'd like to be able to in-context edit an associated HPA.
• As a user, I'd like to be able to see my HPA resource in the sidebar and not be able to change pods as the HPA will fight me

Solution Description:

• Add a Kebab action and modal to support deleting the associated HPA on a workload.
• Using the same form from the Add HPA, allow editing.
• Update to add a resource section for HPAs and to stop manual scaling of the pods; through kebab and scale arrows on the pod donut that is on the details tab.

Screen shots / Gifs for design review:
@openshift/team-devconsole-ux & @lwrigh

When a custom metric is in play, we auto select the YAML - they can still use the Form when they so desire to get access to cpu / memory (if applicable), the hpa name and min/max replica counts.

Sidebar:

Unit test coverage report:

  doesHpaMatch checks if it aligns to a workload
    ✓ expect not to match when hpa does not target workload
    ✓ expect to match when hpa does target workload
  hasCustomMetrics accurately determines if an hpa contains non-default metrics
    ✓ expect no metrics to mean no custom metrics
    ✓ expect cpu and memory metrics to not be custom
    ✓ expect any unknown metric to be custom
    ✓ expect an unknown metric to trump known metrics

------------------------------------------------------------|----------|----------|----------|----------|-------------------|
File                                                        |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
------------------------------------------------------------|----------|----------|----------|----------|-------------------|
  src/components/hpa/hpa-utils.ts                           |    97.26 |    90.63 |      100 |    96.83 |            92,100 |
------------------------------------------------------------|----------|----------|----------|----------|-------------------|

Test setup:

• Add an HPA to a D/DC Workload that is in Topology
• Use the Kebab action to delete || edit
• See Topology Sidebar Details page for no pod scaling and new text

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[vikram-raj]

After adding a HPA I am still seeing the Add HPA option however Remove and Edit HPA option should present. Am I missing something?

[dtaylor113]

@spadgett Another 'Silence Alert' flake where 'Watchdog' isn't listed, although I don't see the 'test for rows' before applying filter test?

[dtaylor113]

/retest

[andrewballantyne]

After adding a HPA I am still seeing the Add HPA option however Remove and Edit HPA option should present. Am I missing something?

Odd, not sure what happened. Somewhere from last week to now through rebases the association code found an unlikely home in the wrong spot. HPAs were not associated with the resource anymore. Should be fixed now though.

[debsmita1]

Suggested change

	if (!hpas?.length) {
	if (hpas?.length === 0) {

[andrewballantyne]

hpas being null won't match 0 absolutely. So that changes the logic. Either we don't have hpas OR we have an array of zero is the logic today, if we wanted to keep that and compare against 0:

Suggested change

	if (!hpas?.length) {
	if (!hpas || hpas.length === 0) {

[jerolimov]

Could verify that the "Edit HPA" menu was shown with the latest commit (97f28cd) 👍

Some comments are still open, but it lgtm. I tested it with local web console on a shared cluster.

[vikram-raj]

Verify all the scenarios and it works as expected.

/lgtm

[andrewballantyne]

I've logged a couple bugs to cover the missing things found:

https://issues.redhat.com/browse/ODC-4411
https://issues.redhat.com/browse/ODC-4412

/assign @christianvogt

Christian, we'll need an approval from you to get this in before EOD tomorrow.

[andrewballantyne]

/retest

[invincibleJai]

/test e2e-gcp-console

[christianvogt]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andrewballantyne]

/retest

[openshift-ci-robot]

@andrewballantyne: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	e530edf	link	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.