Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitoring: Add Source column to alerts and rules lists #6064

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Jul 22, 2020

The source is either "Platform" (platform monitoring) or "User" (user
workload monitoring).

Also adds Source filters to both list pages.

The source is either "Platform" (platform monitoring) or "User" (user
workload monitoring).

Also adds Source filters to both list pages.
@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 22, 2020
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 20e24ff into openshift:master Jul 23, 2020
@kyoto kyoto deleted the monitoring-add-source-column branch July 26, 2020 01:38
@spadgett spadgett added this to the v4.6 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants