HPA in Topology Sidebar #6087
HPA in Topology Sidebar #6087
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrewballantyne The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
component/dev-console
|
/hold Waiting on dependant PR #6039 |
openshift-ci-robot
added
the
do-not-merge/hold
andrewballantyne
force-pushed
the
sidebar-hpa
branch
from
c93e106
to
d7a7c39
Compare
|
@andrewballantyne: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| const obj = get(data, ['current', 'obj'], null) || data.dc; | ||
| const { title, subTitle, titleComponent } = podRingLabel(obj, data.dc.kind, data?.pods); | ||
| const { title, subTitle, titleComponent } = hpaControlledScaling | ||
| ? hpaPodRingLabel(obj, hpa, data?.pods) |
There was a problem hiding this comment.
Why bother reading from the HPA? The workload should continue to have the spec and status needed to populate the pod ring.
|
See #6150 |
Built on #6039 - See the 4th Commit
Fixes:
https://issues.redhat.com/browse/ODC-4272
Analysis / Root cause:
As a user, I'd like to be able to see my HPA resource in the sidebar and not be able to change pods as the HPA will fight me
Solution Description:
Update to add a resource section for HPAs and to stop manual scaling of the pods; through kebab and scale arrows on the pod donut that is on the details tab.
Screen shots / Gifs for design review:
@openshift/team-devconsole-ux & @lwrigh
Browser conformance: