Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin Scritps for ODC-3924 #6129

Merged

Conversation

gajanan-more
Copy link
Contributor

Fixes: https://issues.redhat.com/browse/ODC-4043

Problem: Gherkin Scripts Design for Event Source sink to URI epic ODC-3924

Solution: These are the gherkin scripts designed covering all the scenarios related to Event Source sink to URI epic ODC-3924

@gajanan-more
Copy link
Contributor Author

/assign @sanketpathak

@gajanan-more
Copy link
Contributor Author

/assign @invincibleJai

Copy link
Member

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gajanan-more this looks good, one scenario is if user rt-click eventSource can see move sink on click of it user will show a modal with two radios again with option to sink URI as well

@invincibleJai
Copy link
Member

/approve

@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 29, 2020
Copy link
Contributor

@makambalaji makambalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple of comments, update based on it..
Please make sure the step should give clear understanding while reading it alone

@makambalaji
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2020
@sanketpathak
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, invincibleJai, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bf3036f into openshift:master Jul 29, 2020
@spadgett spadgett added this to the v4.6 milestone Jul 30, 2020
@gajanan-more gajanan-more deleted the sinktoURI-ODC-3924 branch August 7, 2020 09:01
@gajanan-more gajanan-more restored the sinktoURI-ODC-3924 branch August 7, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants