-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gherkin Scritps for ODC-3924 #6129
Gherkin Scritps for ODC-3924 #6129
Conversation
/assign @sanketpathak |
/assign @invincibleJai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gajanan-more this looks good, one scenario is if user rt-click eventSource can see move sink on click of it user will show a modal with two radios again with option to sink URI as well
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
84a2b9e
to
eb08260
Compare
/approve |
eb08260
to
b42d2b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added couple of comments, update based on it..
Please make sure the step should give clear understanding while reading it alone
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
frontend/packages/dev-console/integration-tests/features/Knative/sink-to-URI-ODC-3924.feature
Outdated
Show resolved
Hide resolved
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gajanan-more, invincibleJai, makambalaji, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://issues.redhat.com/browse/ODC-4043
Problem: Gherkin Scripts Design for Event Source sink to URI epic ODC-3924
Solution: These are the gherkin scripts designed covering all the scenarios related to Event Source sink to URI epic ODC-3924