Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide namespace for pipeline, runs, and resources for admin and dev views in a project context #6148

Merged

Conversation

jcaianirh
Copy link
Member

@jcaianirh jcaianirh commented Jul 29, 2020

@jcaianirh
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2020
@dtaylor113
Copy link
Contributor

/retest

@jerolimov
Copy link
Member

/retest

@spadgett
Copy link
Member

It looks like the test failures are because #5799 hasn't merged.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@serenamarie125
Copy link
Contributor

@invincibleJai @andrewballantyne can you guys keep an eye on this? This was a request from PM as part of the Admin work

ps thanks @jcaianirh 👏

@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/retest

@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
@spadgett
Copy link
Member

spadgett commented Aug 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit e69c288 into openshift:master Aug 1, 2020
@andrewballantyne
Copy link
Contributor

@jcaianirh Thanks for update Pipeline resources. I was unaware of this PR until my emails today 😄 @siamaksade will be quite happy to hear 4.6 does not have the namespace column on the Pipeline and Pipeline Run list pages. They were super crammed before this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants