Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide namespace for pipeline, runs, and resources for admin and dev views in a project context #6148

Merged
merged 2 commits into from Aug 1, 2020
Merged

Hide namespace for pipeline, runs, and resources for admin and dev views in a project context #6148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf34ad
Hide namespace for pipeline, runs, and resources for admin and dev vi…
jcaianirh Jul 29, 2020
fcb92aa
update columnId with columnID
jcaianirh Jul 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions ...kages/dev-console/src/components/pipeline-resources/list-page/PipelineResourcesHeader.tsx
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ const PipelineResourcesHeader = () => {
sortField: 'metadata.namespace',
transforms: [sortable],
props: { className: tableColumnClasses[1] },
id: 'namespace',
},
{
title: 'Type',
Expand Down
2 changes: 1 addition & 1 deletion ...packages/dev-console/src/components/pipeline-resources/list-page/PipelineResourcesRow.tsx
View file
Open in desktop
Expand Up @@ -21,7 +21,7 @@ const PipelineResourcesRow: RowFunction<PipelineResourceKind> = ({ obj, index, k
data-test-id={obj.metadata.name}
/>
</TableData>
<TableData className={tableColumnClasses[1]}>
<TableData className={tableColumnClasses[1]} columnID="namespace">
<ResourceLink kind="Namespace" name={obj.metadata.namespace} />
</TableData>
<TableData className={tableColumnClasses[2]}>
Expand Down
1 change: 1 addition & 0 deletions frontend/packages/dev-console/src/components/pipelineruns/list-page/PipelineRunHeader.tsx
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ const PipelineRunHeader = () => {
sortField: 'metadata.namespace',
transforms: [sortable],
props: { className: tableColumnClasses[1] },
id: 'namespace',
},
{
title: 'Status',
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/dev-console/src/components/pipelineruns/list-page/PipelineRunRow.tsx
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ const PipelineRunRow: RowFunction<PipelineRun> = ({ obj, index, key, style }) =>
data-test-id={obj.metadata.name}
/>
</TableData>
<TableData className={tableColumnClasses[1]}>
<TableData className={tableColumnClasses[1]} columnID="namespace">
<ResourceLink kind="Namespace" name={obj.metadata.namespace} />
</TableData>
<TableData className={tableColumnClasses[2]}>
Expand Down
1 change: 1 addition & 0 deletions frontend/packages/dev-console/src/components/pipelines/list-page/PipelineHeader.tsx
View file
Open in desktop
Expand Up @@ -14,6 +14,7 @@ const PipelineHeader = () => {
sortField: 'metadata.namespace',
transforms: [sortable],
props: { className: tableColumnClasses[1] },
id: 'namespace',
},
{
title: 'Last Run',
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/dev-console/src/components/pipelines/list-page/PipelineRow.tsx
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ const PipelineRow: RowFunction<Pipeline> = ({ obj, index, key, style }) => {
title={obj.metadata.name}
/>
</TableData>
<TableData className={tableColumnClasses[1]}>
<TableData className={tableColumnClasses[1]} columnID="namespace">
<ResourceLink kind="Namespace" name={obj.metadata.namespace} />
</TableData>
<TableData className={tableColumnClasses[2]}>
Expand Down