Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new serverless application tour and few text changes #6177

Merged
merged 1 commit into from Jul 31, 2020
Merged

Add a new serverless application tour and few text changes #6177

merged 1 commit into from Jul 31, 2020

Conversation

rohitkrai03
Copy link
Contributor

Fixes - https://issues.redhat.com/browse/ODC-4201.

This PR -

  • Adds a new quick start tour for Creating a serverless application.
  • Adds a few minor text changes in other tours based on UX recommendations.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Jul 31, 2020
@abhinandan13jan
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2020
@christianvogt
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, christianvogt, invincibleJai, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2020
@openshift-ci-robot
Copy link
Contributor

@rohitkrai03: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 6a3606b link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andrewballantyne
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9958d52 into openshift:master Jul 31, 2020
@spadgett spadgett added this to the v4.6 milestone Aug 1, 2020
@rohitkrai03 rohitkrai03 deleted the quick-starts branch July 24, 2021 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@invincibleJai invincibleJai

@abhinandan13jan abhinandan13jan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@rohitkrai03 @abhinandan13jan @invincibleJai @christianvogt @openshift-ci-robot @andrewballantyne @spadgett @openshift-merge-robot