-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support schema-grouped descriptor arrays on operand details page #6178
Support schema-grouped descriptor arrays on operand details page #6178
Conversation
/assign @spadgett |
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheRealJon, do you mind adding a screenshot?
frontend/packages/operator-lifecycle-manager/src/components/descriptors/index.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/descriptors/index.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/descriptors/const.ts
Outdated
Show resolved
Hide resolved
cc @tlwu2013 |
Implement descriptor groups for descriptors which reference array values. Story: https://issues.redhat.com/browse/CONSOLE-2283 Sub-task: https://issues.redhat.com/browse/CONSOLE-2328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
justify-content: start; | ||
& > div { | ||
margin-right: var(--pf-global--spacer--sm); | ||
flex-grow: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: alpha
|
||
// Replace '.', '[', and '].' with '/'. | ||
export const getPatchPathFromDescriptor = (descriptor: Descriptor): string => | ||
_.toPath(descriptor.path).join('/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't new, but we probably need to account for escaping special characters. Let's deal with that separately, though.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Implement descriptor groups for descriptors which reference array values.
YAML
Spec Descriptors:
Story: https://issues.redhat.com/browse/CONSOLE-2283
Sub-task: https://issues.redhat.com/browse/CONSOLE-2328