Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1868070: Updates to content for quick starts #6307

Merged
merged 12 commits into from Sep 10, 2020
Merged

Bug 1868070: Updates to content for quick starts #6307

merged 12 commits into from Sep 10, 2020

Conversation

serenamarie125
Copy link
Contributor

@serenamarie125 serenamarie125 commented Aug 12, 2020 •
edited

Updates the content of the 4 existing quick starts and add 3 missing dev quick starts:

  • Create sample app
  • Add health checks
  • Monitor sample app

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1868070

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Aug 12, 2020
@serenamarie125
Copy link
Contributor Author

FYI @christianvogt @rohitkrai03

@serenamarie125
Copy link
Contributor Author

/assign rohitkrai03

@serenamarie125
Copy link
Contributor Author

/unassign

@serenamarie125
Copy link
Contributor Author

serenamarie125 commented Aug 12, 2020 •
edited

Note that there is no icon associated with these quick starts. When the PR from @rohitkrai03 is merged, the default icon will be displayed. Here's animated gifs of the 3 quick starts:

Getting Started with a sample
GettingStartedWithASample

Adding Health Checks
AddingHealthChecks

Monitoring your Sample App
MonitoringYourSampleApp

Gifs for design review:
@openshift/team-devconsole-ux

@rohitkrai03
Copy link
Contributor

/retest

rohitkrai03
rohitkrai03 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified locally. This is how it looks with changes from #6254 for default fallback icons.
Peek 2020-08-12 09-22

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020
@rohitkrai03
Copy link
Contributor

/assign @christianvogt

@serenamarie125
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor

/retitle Bug 1868070: Add 3 missing dev quick starts

@openshift-ci-robot openshift-ci-robot changed the title Add 3 missing dev quick starts Bug 1868070: Add 3 missing dev quick starts Aug 17, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@serenamarie125: This pull request references Bugzilla bug 1868070, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1868070: Add 3 missing dev quick starts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 17, 2020
@abhi-kn
Copy link
Contributor

abhi-kn commented Aug 17, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 17, 2020
@openshift-ci-robot
Copy link
Contributor

@abhi-kn: This pull request references Bugzilla bug 1868070, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhi-kn
Copy link
Contributor

abhi-kn commented Aug 17, 2020

/retest

@andrewballantyne
Copy link
Contributor

/retest

Not sure I understand the cypress errors... but I'll keep an eye on what is failing.

@andrewballantyne
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Aug 26, 2020
@andrewballantyne
Copy link
Contributor

@serenamarie125 There appears to be conflicts -- please rebase on the latest master and resolve them.

Once you are confident that the content has gone through the last set of changes, please re-request review from the DevConsole team for the lgtm label. It seems this is getting reviewed multiple times and then re-reviewed after a new commit comes in. Best to just limit the round trips if at all possible.

Thanks in advance!

cc @rohitkrai03

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2020
@serenamarie125
Copy link
Contributor Author

/retest

@serenamarie125
Copy link
Contributor Author

/retest

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jerolimov, rohitkrai03, serenamarie125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

@serenamarie125: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console d969ca1 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit b21a100 into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@serenamarie125: All pull requests linked via external trackers have merged:

Bugzilla bug 1868070 has been moved to the MODIFIED state.

In response to this:

Bug 1868070: Updates to content for quick starts

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Sep 11, 2020
@andrewballantyne
Copy link
Contributor

For posterity, the Jira ticket is: https://issues.redhat.com/browse/ODC-4438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Preeticp Preeticp Preeticp left review comments

@maxwelldb maxwelldb maxwelldb requested changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@jerolimov jerolimov Awaiting requested review from jerolimov

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@rohitkrai03 rohitkrai03

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet