-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1868471: Add paused state to MachineConfigPool list view #6322
Conversation
@jcaianirh: This pull request references Bugzilla bug 1868471, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add this to the details page as well if it's not there.
if (_.isUndefined(obj.spec?.paused)) { | ||
return 'Unknown'; | ||
} | ||
return obj.spec?.paused ? 'True' : 'False'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's undefined, it's not paused. So this can be just
if (_.isUndefined(obj.spec?.paused)) { | |
return 'Unknown'; | |
} | |
return obj.spec?.paused ? 'True' : 'False'; | |
return obj.spec?.paused ? 'True' : 'False'; |
I'd inline it below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spadgett I started with that but noticed that the other status differentiates between unknown and false. When you create a new mcp you can see them all show the same result. Transitioning between unknown and false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcaianirh Conditions have different semantics. We want false here for paused because spec.paused
is always treated as false if missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spadgett thanks for clearing that up!
@spadgett added to details page, and removed unknown state. |
@jcaianirh: This pull request references Bugzilla bug 1868471, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaianirh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jcaianirh: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@jcaianirh: All pull requests linked via external trackers have merged: openshift/console#6322. Bugzilla bug 1868471 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix for: https://bugzilla.redhat.com/show_bug.cgi?id=1868471