Add CDI Upload integration test #6338

glekner · 2020-08-17T14:05:25Z

No description provided.

openshift-ci-robot · 2020-08-17T14:05:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glekner
To complete the pull request process, please assign mareklibra
You can assign the PR to them by writing /assign @mareklibra in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/packages/kubevirt-plugin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

glekner · 2020-08-18T11:56:34Z

/retest

gouyang · 2020-08-19T08:53:48Z

Test case for this: https://polarion.engineering.redhat.com/polarion/#/project/CNV/workitem?id=CNV-4718

gouyang · 2020-08-19T09:13:02Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+} from '@console/ceph-storage-plugin/integration-tests/views/pvc.view';
+
+describe('KubeVirt CDI Upload', () => {
+  const pvc = { name: 'upload-pvc', size: 1, unit: 'Gi', storageClassName: 'rook-ceph' };


rook-ceph is not on 4.5/4.6, we can use 'standard' for safety.

can we use the STORAGE_CLASS env variable?

STORAGE_CLASS is defined in utils/constants/common.ts, can just use it.

gouyang · 2020-08-19T09:14:33Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+      await click(saveChangesBtn);
+      await browser.wait(until.textToBePresentInElement(cdiUploadView.uploadProgress, '100%'));
+    },
+    VM_CREATE_AND_EDIT_TIMEOUT_SECS,


It should use a more proper timeout constants here, maybe CDI_UPLOAD_TIMEOUT_SECS.

atiratree · 2020-08-19T09:20:08Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+  it(
+    'ID() Upload data to CDI',
+    async () => {
+      const fileToUpload = '../views/cdiUploadView.ts';


we should have a dedicated file for the upload

I'm against making the console repo larger in size, if we're talking about creating a new txt file its fine by me.

just a simple text file is fine. We just don't want to depend on a random source file, which could change a location for example due to refactoring.

atiratree · 2020-08-19T09:21:10Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+      });
+      await cdiUploadView.uploadInput.sendKeys(absolutePath);
+      await click(saveChangesBtn);
+      await browser.wait(until.textToBePresentInElement(cdiUploadView.uploadProgress, '100%'));


can we start a VM/container and check the file/content is there?

this is outside our scope, the responsibility of this UI section is to upload a file, what you're talking about is the CDI responsibility.
We can however go to the PVCs page and check that the pvc is there and bounded

start a VM needs the upload file is a truly vm image, we can do it in tier2 test for this card: https://issues.redhat.com/browse/CNV-6020.

it is not out of the scope, because we are doing final integration tests here. And we can't just depend on a simple status to check that everything went well.

ok we can move it to tier2 tests then @gouyang can you create a description for this test please?

add a comment to https://issues.redhat.com/browse/CNV-6020

added comment @gouyang

atiratree · 2020-08-19T09:23:46Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+} from '@console/ceph-storage-plugin/integration-tests/views/pvc.view';
+
+describe('KubeVirt CDI Upload', () => {
+  const pvc = { name: 'upload-pvc', size: 1, unit: 'Gi', storageClassName: 'rook-ceph' };


the unit is not used. Anyway we could be using a smaller size, since 1Gi is a bit of overkill for a small text file

need at least 100MB for the dv to initiate succesfully

atiratree · 2020-08-19T09:26:55Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+      await selectItemFromDropdown(pvc.storageClassName, storageclassDropdown);
+
+      // firefox needs the input to be shown
+      await browser.executeAsyncScript(function(callback) {


do you have some more info on this? The input is visible by default, no?

default is:

firefox needs the input to be shown like this: (just for tests)

Our tests is running against chrome only, it's can be removed if it's firefox specific.

but developers can run this test locally with firefox?

If it has no side affect to run it with chrome, I'm okay with it.

glekner · 2020-08-19T10:28:06Z

now selects the first available storage class
size changed to 100 MiB
added ID

@gouyang @suomiy

atiratree · 2020-08-19T11:06:54Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+
+      await inputPVCName.sendKeys(pvc.name);
+      await inputPVCSize.sendKeys(pvc.size);
+      await click(cdiUploadView.unitDropdown);


can we use selectDropdownOption here instead?

selectDropdownOption needs a specific option.
since the classes are dynamic, its safer to just pick the first option.

It seems the same function is used by selectNetworkTypeByID which is testing the same underlying component Dropdown.
Is there some issue with using the same approach here?

glekner · 2020-08-19T11:12:09Z

@suomiy

added a mock text file for upload

atiratree · 2020-08-19T12:54:31Z

@glekner highlighting #6338 (comment)

openshift-ci-robot · 2020-08-19T16:34:01Z

@glekner: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-gcp-console	`70eefc5`	link	`/test e2e-gcp-console`
ci/prow/images	`70eefc5`	link	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

gouyang · 2020-09-11T07:00:28Z

I passed the test locally with a few changes.

await inputPVCName.sendKeys(pvc.name); this line does not work, it says element not interactable. I use fillInput from @console/shared/src/test-utils/utils.
The first item of storage class is csi-manila-ceph in my cluster, it does not work. Can leave it and use the default value which comes from kubevirt-storage-class-defaults, or specify via STORAGE_CLASS.
The text file is not supported format, I use execSync pulling down cirros image to /tmp and use it for test.
The size should be 1Gib for cirros image.
Use upload-pvc-${testName} for PVC name.

gouyang · 2020-09-11T07:18:34Z

And it would be better to clean the created dv/pvc after the test.

gouyang · 2020-09-24T03:32:34Z

I created a follow-up PR #6735 for this.

glekner · 2020-09-24T08:20:51Z

Thanks @gouyang . closing in favour of #6735

openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Aug 17, 2020

openshift-ci-robot requested review from jelkosz and atiratree August 17, 2020 14:05

glekner force-pushed the test-cdi-upload branch from ff59354 to e7224ab Compare August 17, 2020 14:08

glekner force-pushed the test-cdi-upload branch from e7224ab to 63ba174 Compare August 19, 2020 07:57

gouyang reviewed Aug 19, 2020

View reviewed changes

atiratree suggested changes Aug 19, 2020

View reviewed changes

glekner force-pushed the test-cdi-upload branch from 63ba174 to 995c56c Compare August 19, 2020 10:27

glekner force-pushed the test-cdi-upload branch from 995c56c to 023217f Compare August 19, 2020 10:33

atiratree suggested changes Aug 19, 2020

View reviewed changes

glekner force-pushed the test-cdi-upload branch from 023217f to ad36937 Compare August 19, 2020 11:11

add cdi upload integration test

70eefc5

glekner force-pushed the test-cdi-upload branch from ad36937 to 70eefc5 Compare August 19, 2020 12:32

glekner closed this Sep 24, 2020

glekner deleted the test-cdi-upload branch September 24, 2020 08:20

Add CDI Upload integration test #6338

Add CDI Upload integration test #6338

Conversation

glekner commented Aug 17, 2020

openshift-ci-robot commented Aug 17, 2020

glekner commented Aug 18, 2020

gouyang commented Aug 19, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gouyang Aug 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glekner commented Aug 19, 2020 • edited

Choose a reason for hiding this comment

glekner Aug 19, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

glekner commented Aug 19, 2020

atiratree commented Aug 19, 2020

openshift-ci-robot commented Aug 19, 2020

gouyang commented Sep 11, 2020

gouyang commented Sep 11, 2020

gouyang commented Sep 24, 2020

glekner commented Sep 24, 2020

gouyang Aug 19, 2020 •

edited

glekner commented Aug 19, 2020 •

edited

glekner Aug 19, 2020 •

edited