Bug 1882197: Add test for golden image upload #6735

gouyang · 2020-09-24T03:30:36Z

note: create vm from the golden OS is not included in this test.

openshift-ci-robot · 2020-09-24T03:30:39Z

@gouyang: This pull request references Bugzilla bug 1882197, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1882197: Add test for golden image upload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-24T03:30:59Z

Hi @gouyang. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

atiratree · 2020-09-24T16:02:01Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+  });
+
+  afterAll(async () => {
+    execSync(`kubectl delete -n ${testName} dv ${pvc.name}`);


what about the upload token, if something goes wrong? @glekner is there something else we should take care about?

it doesn't need to handle the upload token, the framework handle it automatically.

I am wondering if such objects can stay alive if the execution fails?

It stays alive if the execution fails until the ns is removed.

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

atiratree · 2020-09-24T16:07:57Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+      });
+      await cdiUploadView.uploadInput.sendKeys(desImage);
+      await click(saveChangesBtn);
+      await browser.wait(until.textToBePresentInElement(cdiUploadView.uploadProgress, '100%'));


can we check the final PVC exists?

Add a step to verify the PVC is in Bound status.

frontend/packages/kubevirt-plugin/integration-tests/views/cdiUploadView.ts

atiratree · 2020-09-24T16:09:04Z

/ok-to-test

gouyang · 2020-09-25T07:12:53Z

@suomiy I rewrite the tests, could you please review again?

atiratree · 2020-09-25T11:36:42Z

frontend/packages/kubevirt-plugin/integration-tests/tests/models/pvcUploadForm.ts

+import * as cdiUploadView from '../../views/cdiUploadView';
+import { PVCData } from '../types/pvc';
+
+export class UploadForm {


nice refactoring :)

atiratree · 2020-09-25T11:44:24Z

frontend/packages/kubevirt-plugin/integration-tests/tests/cdi-upload.scenario.ts

+  });
+
+  afterAll(async () => {
+    execSync(`kubectl delete -n ${testName} dv ${pvcName}`);


shouldn't we also delete the downloaded image?

Updated, delete the downloaded image also.

atiratree · 2020-09-25T12:44:04Z

/lgtm

openshift-ci-robot · 2020-09-25T12:44:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/packages/kubevirt-plugin/OWNERS~~ [suomiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2020-09-25T17:50:35Z

/bugzilla refresh

openshift-ci-robot · 2020-09-25T17:50:42Z

@suomiy: This pull request references Bugzilla bug 1882197, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-09-25T21:49:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-26T08:13:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-26T08:26:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-26T10:13:09Z

@gouyang: All pull requests linked via external trackers have merged:

openshift/console#6735

Bugzilla bug 1882197 has been moved to the MODIFIED state.

In response to this:

Bug 1882197: Add test for golden image upload

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 24, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Sep 24, 2020

openshift-ci-robot requested review from atiratree and vojtechszocs September 24, 2020 03:30

openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2020

gouyang mentioned this pull request Sep 24, 2020

Add CDI Upload integration test #6338

Closed

atiratree suggested changes Sep 24, 2020

View reviewed changes

openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 24, 2020

gouyang force-pushed the cdi branch from 122c7e6 to d7597b0 Compare September 25, 2020 07:09

atiratree reviewed Sep 25, 2020

View reviewed changes

atiratree suggested changes Sep 25, 2020

View reviewed changes

gouyang force-pushed the cdi branch from d7597b0 to 329a801 Compare September 25, 2020 11:59

Bug 1882197: Add test for golden image upload

ea90e82

gouyang force-pushed the cdi branch from 329a801 to ea90e82 Compare September 25, 2020 12:02

openshift-ci-robot assigned atiratree Sep 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 25, 2020

openshift-merge-robot merged commit a7a2761 into openshift:master Sep 26, 2020

spadgett added this to the v4.6 milestone Sep 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1882197: Add test for golden image upload #6735

Bug 1882197: Add test for golden image upload #6735

gouyang commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

atiratree Sep 24, 2020

gouyang Sep 25, 2020

atiratree Sep 25, 2020

gouyang Sep 25, 2020

atiratree Sep 25, 2020

atiratree Sep 24, 2020

gouyang Sep 25, 2020

atiratree commented Sep 24, 2020

gouyang commented Sep 25, 2020

atiratree Sep 25, 2020

atiratree Sep 25, 2020

gouyang Sep 25, 2020

atiratree commented Sep 25, 2020

openshift-ci-robot commented Sep 25, 2020

atiratree commented Sep 25, 2020

openshift-ci-robot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 26, 2020

openshift-bot commented Sep 26, 2020

openshift-ci-robot commented Sep 26, 2020

Bug 1882197: Add test for golden image upload #6735

Bug 1882197: Add test for golden image upload #6735

Conversation

gouyang commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

openshift-ci-robot commented Sep 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Sep 24, 2020

gouyang commented Sep 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atiratree commented Sep 25, 2020

openshift-ci-robot commented Sep 25, 2020

atiratree commented Sep 25, 2020

openshift-ci-robot commented Sep 25, 2020

openshift-bot commented Sep 25, 2020

openshift-bot commented Sep 26, 2020

openshift-bot commented Sep 26, 2020

openshift-ci-robot commented Sep 26, 2020