-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1870556: Gherkin script for quick starts-ODC4077 #6358
Bug 1870556: Gherkin script for quick starts-ODC4077 #6358
Conversation
@@ -0,0 +1,201 @@ | |||
Feature: Creating a Serverless application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the file name? There is extra space between with and _
3669b7b
to
d2faae2
Compare
The scenarios look good. |
d2faae2
to
a47be3a
Compare
@sanketpathak: This pull request references Bugzilla bug 1870556, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@sanketpathak: This pull request references Bugzilla bug 1870556, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The scenarios look good to me. I am not sure of how it runs |
/lgtm |
Given user is in +Add page | ||
And user sees quick tour card | ||
When user clicks on the "Creating a Serverless application" link on the card | ||
And user can see the tour will start as a sidescreen with close button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And user can see the tour will start as a sidescreen with close button | |
And user sees the tour will start as a sidescreen with close button |
Can you please update all the when statements accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You haven't added background in any files. Can you please add it?
a47be3a
to
aeeefed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of then statement is performing a action which shouldn't be the case. Can you please update those then statements?
Then user sees the security alert appearing on top saying "This tour has already been completed" | ||
And user sees Knative Cookbook link | ||
And user sees "Close", "Back" and "View all tours" | ||
And user clicks "View all tours" button to see all tour options in background |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then statement should not perform any action. Can you please update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are required actions that need to be present in the given result
Then user sees the security alert appearing on top saying "This tour has already been completed" | ||
And user sees Knative Cookbook link | ||
And user sees "Close", "Back" and "View all tours" | ||
And user clicks "View all tours" button to see all tour options in background |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then statement should not perform any action. Can you please update it?
And user sees an alert appears "Check your work" asking to verify that the Serverless Operator was successfully installed | ||
And user selects No option | ||
Then user sees that the alert is saying "Try walking through the steps again to properly install Serverless Operator" | ||
And user clicks on next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then statement should not perform any action. Can you please update it?
And user sees an alert appears "Check your work" asking to verify that the Serverless Operator was successfully installed | ||
And user selects No option | ||
Then user sees that the alert is saying "Try walking through the steps again to properly install Serverless Operator" | ||
And user clicks on next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then statement should not perform any action. Can you please update it?
Then user sees the security alert appearing on top saying "This tour has already been completed" | ||
And user sees Start serverless-application quick start link | ||
And user sees "Close" and "Back" | ||
And user clicks "Back" button to go back to previous "Check your work" alert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then statement should not perform any action. Can you please update it?
1a78929
to
586cbd7
Compare
586cbd7
to
aa730c6
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinandan13jan, gajanan-more, makambalaji, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@sanketpathak: All pull requests linked via external trackers have merged: openshift/console#6358. Bugzilla bug 1870556 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gherkin script for the guided tour
Epic: https://issues.redhat.com/browse/ODC-3203
Story: https://issues.redhat.com/browse/ODC-4077