Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1870556: Gherkin script for quick starts-ODC4077 #6358

Merged
merged 1 commit into from Aug 23, 2020
Merged

Bug 1870556: Gherkin script for quick starts-ODC4077 #6358

merged 1 commit into from Aug 23, 2020

Conversation

sanketpathak
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Aug 18, 2020
gajanan-more
gajanan-more suggested changes Aug 19, 2020
View reviewed changes
...on-tests/features/guided-tour/import_an_application_and_associate_a_pipeline_with _t.feature Outdated
@@ -0,0 +1,201 @@
Feature: Creating a Serverless application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update the file name? There is extra space between with and _

@abhinandan13jan
Copy link
Contributor

The scenarios look good.
Please fix the PR title.
I believe, one scenario can be added. Going backways into Task as in a QuickStart with 3 tasks, a user can go back to Task1 while she is at Task2. So, something like Task2 -> Task1 could be a scenario.

@sanketpathak sanketpathak changed the title gherin script for guided tour-ODC4077 Gherkin script for quick start-ODC4077 Aug 20, 2020
@sanketpathak sanketpathak changed the title Gherkin script for quick start-ODC4077 Gherkin script for quick starts-ODC4077 Aug 20, 2020
@sanketpathak sanketpathak changed the title Gherkin script for quick starts-ODC4077 Bug 1870556: Gherkin script for quick starts-ODC4077 Aug 20, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Bugzilla bug 1870556, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870556: Gherkin script for quick starts-ODC4077

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2020
@sanketpathak
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Bugzilla bug 1870556, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 20, 2020
@abhinandan13jan
Copy link
Contributor

The scenarios look good to me. I am not sure of how it runs

@abhinandan13jan
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
gajanan-more
gajanan-more suggested changes Aug 20, 2020
View reviewed changes
...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
Given user is in +Add page
And user sees quick tour card
When user clicks on the "Creating a Serverless application" link on the card
And user can see the tour will start as a sidescreen with close button
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And user can see the tour will start as a sidescreen with close button
And user sees the tour will start as a sidescreen with close button

Can you please update all the when statements accordingly?

gajanan-more
gajanan-more suggested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't added background in any files. Can you please add it?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020
gajanan-more
gajanan-more suggested changes Aug 21, 2020
View reviewed changes
Copy link
Contributor

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of then statement is performing a action which shouldn't be the case. Can you please update those then statements?

...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
Then user sees the security alert appearing on top saying "This tour has already been completed"
And user sees Knative Cookbook link
And user sees "Close", "Back" and "View all tours"
And user clicks "View all tours" button to see all tour options in background
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then statement should not perform any action. Can you please update it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are required actions that need to be present in the given result

...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
Then user sees the security alert appearing on top saying "This tour has already been completed"
And user sees Knative Cookbook link
And user sees "Close", "Back" and "View all tours"
And user clicks "View all tours" button to see all tour options in background
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then statement should not perform any action. Can you please update it?

...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
And user sees an alert appears "Check your work" asking to verify that the Serverless Operator was successfully installed
And user selects No option
Then user sees that the alert is saying "Try walking through the steps again to properly install Serverless Operator"
And user clicks on next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then statement should not perform any action. Can you please update it?

...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
And user sees an alert appears "Check your work" asking to verify that the Serverless Operator was successfully installed
And user selects No option
Then user sees that the alert is saying "Try walking through the steps again to properly install Serverless Operator"
And user clicks on next
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then statement should not perform any action. Can you please update it?

...ev-console/integration-tests/features/guided-tour/creating_a _serverless_application.feature Outdated
Then user sees the security alert appearing on top saying "This tour has already been completed"
And user sees Start serverless-application quick start link
And user sees "Close" and "Back"
And user clicks "Back" button to go back to previous "Check your work" alert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then statement should not perform any action. Can you please update it?

@sanketpathak sanketpathak force-pushed the gherin-guided-tour-ODC4077 branch 2 times, most recently from 1a78929 to 586cbd7 Compare August 21, 2020 11:54
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2020
@makambalaji
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, gajanan-more, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 685eef2 into openshift:master Aug 23, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: All pull requests linked via external trackers have merged: openshift/console#6358. Bugzilla bug 1870556 has been moved to the MODIFIED state.

In response to this:

Bug 1870556: Gherkin script for quick starts-ODC4077

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.6 milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gajanan-more gajanan-more gajanan-more requested changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@gajanan-more gajanan-more

@abhinandan13jan abhinandan13jan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sanketpathak @abhinandan13jan @openshift-ci-robot @gajanan-more @makambalaji @openshift-bot @spadgett @openshift-merge-robot