-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1862500: Use initialization-resource annotation for yaml #6393
Conversation
@zherman0: This pull request references Bugzilla bug 1862500, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
frontend/packages/operator-lifecycle-manager/src/components/index.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/index.tsx
Outdated
Show resolved
Hide resolved
@zherman0: This pull request references Bugzilla bug 1862500, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@spadgett - Reworked my logic and now I handle the combination of almExamples and Initialization-resource examples. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zherman0 I think it's simpler just to have a query parameter that is passed in the URL saying to use the initialization resource. If it's set, use the initialization resource. Otherwise always use alm-examples
like before.
@zherman0: This pull request references Bugzilla bug 1862500, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@spadgett - Switched logic to use URL flag. Ready for review. |
frontend/packages/operator-lifecycle-manager/src/components/index.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/index.tsx
Outdated
Show resolved
Hide resolved
@spadgett - Moved the check for the URL flag out of the parse helper function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zherman0: All pull requests linked via external trackers have merged: Bugzilla bug 1862500 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If the initialization-resource annotation value is set for a CR, use it on the yaml pages instead of the alm-example annotation.
Note to self: For testing, use TW's operators that have CR values set in the initialization-resource annotation and then do a patch to change the values from the alm-example:
oc patch csv portworx-operator.v1.3.1 --patch "$(cat ~/openshift/portworx-test.json)" --type=merge
and portworx-test.json looks like: