Bug 1875440: Make pipeline task parameter editable (if it was only defined in the pipeline, not in the task)

[jerolimov]

Fixes:
https://issues.redhat.com/browse/ODC-4414
https://bugzilla.redhat.com/show_bug.cgi?id=1875440

Analysis / Root cause:
When editing a generated pipeline PATH_CONTEXT is not editable. Root cause is that the task param is not editable if it was only defined in the pipeline params section and not in the tasks params section.

Solution Description:
Extend the method which updates the Pipeline -> selected task -> params section that it automatically adds a param if the param does not exist yet.

Screen shots / Gifs for design review:

Unit test coverage report:
Add some tests, will not change the coverage

Test setup:

1. Install the OpenShift Pipelines Operator
2. Import a Java app via import Git flow and check "add pipeline"
3. Go to pipeline and edit pipeline to open it up in the pipeline builder
4. Click on the "build" task
5. Edit the PATH_CONTEXT param

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[openshift-ci-robot]

@jerolimov: This pull request references Bugzilla bug 1875440, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1875440: Add a new PipelineTask param if the param does not exist yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jerolimov]

/assign @andrewballantyne

[jerolimov]

/kind bug

[rottencandy]

/lgtm

[andrewballantyne]

Awesome, thanks for these tests... My refactor PR has a few as well, but it has missed 2 releases. It needs to be done for 4.7, so I'll start rebasing and aligning next sprint to merge as Master opens.

[andrewballantyne]

Not sure why Sauds LGTM didn't go through lol

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jerolimov, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/dev-console/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jerolimov: All pull requests linked via external trackers have merged:

• openshift/console#6520

Bugzilla bug 1875440 has been moved to the MODIFIED state.

In response to this:

Bug 1875440: Make pipeline task parameter editable (if it was only defined in the pipeline, not in the task)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.