Bug 1875440: Make pipeline task parameter editable (if it was only defined in the pipeline, not in the task)

frontend/packages/dev-console/src/components/pipelines/pipeline-builder/__tests__/update-utils.spec.ts

@@ -0,0 +1,84 @@
+import { PipelineTask } from '../../../../utils/pipeline-augment';
+import { applyParamsUpdate } from '../update-utils';
+import { UpdateTaskParamData } from '../types';
+
+describe('applyParamsUpdate', () => {
+  it('change an existing task param', () => {
+    const inputTask: PipelineTask = {
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+      params: [
+        { name: 'EXISTING_TASK_PARAM', value: 'old value' },
+        { name: 'ANOTHER_EXISTING_TASK_PARAM', value: 'ignored value' },
+      ],
+    };
+    const params: UpdateTaskParamData = {
+      newValue: 'new value',
+      taskParamName: 'EXISTING_TASK_PARAM',
+    };
+    const updatedTask = applyParamsUpdate(inputTask, params);
+    expect(updatedTask).not.toBe(inputTask);
+    expect(updatedTask.params).not.toBe(inputTask.params);
+    expect(updatedTask).toEqual({
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+      params: [
+        { name: 'EXISTING_TASK_PARAM', value: 'new value' },
+        { name: 'ANOTHER_EXISTING_TASK_PARAM', value: 'ignored value' },
+      ],
+    });
+  });
+
+  it('change a non-existing task param', () => {
+    const inputTask: PipelineTask = {
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+      params: [{ name: 'ANOTHER_EXISTING_TASK_PARAM', value: 'ignored value' }],
+    };
+    const params: UpdateTaskParamData = {
+      newValue: 'new value',
+      taskParamName: 'NEW_TASK_PARAM',
+    };
+    const updatedTask = applyParamsUpdate(inputTask, params);
+    expect(updatedTask).not.toBe(inputTask);
+    expect(updatedTask.params).not.toBe(inputTask.params);
+    expect(updatedTask).toEqual({
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+      params: [
+        { name: 'ANOTHER_EXISTING_TASK_PARAM', value: 'ignored value' },
+        { name: 'NEW_TASK_PARAM', value: 'new value' },
+      ],
+    });
+  });
+
+  it('change a non-existing task param in a task without any param', () => {
+    const inputTask: PipelineTask = {
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+    };
+    const params: UpdateTaskParamData = {
+      newValue: 'new value',
+      taskParamName: 'NEW_TASK_PARAM',
+    };
+    const updatedTask = applyParamsUpdate(inputTask, params);
+    expect(updatedTask).not.toBe(inputTask);
+    expect(updatedTask).toEqual({
+      name: 'pipeline-task',
+      taskRef: {
+        name: 'task',
+      },
+      params: [{ name: 'NEW_TASK_PARAM', value: 'new value' }],
+    });
+  });
+});

frontend/packages/dev-console/src/components/pipelines/pipeline-builder/update-utils.ts

@@ -1,5 +1,5 @@
 import * as _ from 'lodash';
-import { getRandomChars } from '@console/shared/src/utils';
+import { getRandomChars } from '@console/shared';
 import {
   PipelineResourceTask,
   PipelineTask,
@@ -306,26 +306,37 @@ const applyResourceUpdate = (
   };
 };
 
-const applyParamsUpdate = (
+export const applyParamsUpdate = (
   pipelineTask: PipelineTask,
   params: UpdateTaskParamData,
 ): PipelineTask => {
   const { newValue, taskParamName } = params;
 
-  return {
-    ...pipelineTask,
-    params: pipelineTask.params.map(
+  let foundParam = false;
+  const changedParams =
+    pipelineTask.params?.map(
       (param): PipelineTaskParam => {
         if (param.name !== taskParamName) {
           return param;
         }
-
+        foundParam = true;
         return {
           ...param,
           value: newValue,
         };
       },
-    ),
+    ) || [];
+
+  if (!foundParam) {
+    changedParams.push({
+      name: taskParamName,
+      value: newValue,
+    });
+  }
+
+  return {
+    ...pipelineTask,
+    params: changedParams,
   };
 };