Bug 1875770: Test for PVC clone #6528

cloudbehl · 2020-09-04T10:38:28Z

Dependency: #6436
Signed-off-by: Ankush Behl cloudbehl@gmail.com

openshift-ci-robot · 2020-09-04T10:38:38Z

@cloudbehl: This pull request references Bugzilla bug 1875770, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1875770: Test for PVC clone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts

cloudbehl · 2020-09-08T17:59:20Z

@dtaylor113 can you please review?

bipuladh · 2020-09-10T10:48:46Z

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts

+    cy.exec(`oc get pvc ${PVC.metadata.name}-clone -n ${testName} -o json`)
+      .its('stdout')
+      .then((res) => {
+        const pvc = JSON.parse(res);
+        cy.get(DetailsPageSelector.name).contains(pvc.metadata.name);
+        cy.get(DetailsPageSelector.namespace).contains(pvc.metadata.namespace);
+        cy.byTestID('pvc-requested-capacity').contains(`${cloneSize} GiB`);
+      });


I don't think this call is required as most of these values can be deciphered from the PVC request object, cloneSize and testName.

bipuladh · 2020-09-11T06:33:35Z

/assign @dtaylor113 @spadgett

spadgett · 2020-09-11T15:55:58Z

frontend/public/components/utils/request-size-input.tsx

@@ -67,4 +68,5 @@ export type RequestSizeInputProps = {
  minValue?: number;
  inputClassName?: string;
  inputID?: string;
+  dataTestId?: string;


Suggested change

dataTestId?: string;

testID?: string;

spadgett · 2020-09-11T16:00:02Z

/assign @dtaylor113

dtaylor113 · 2020-09-11T16:24:40Z

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts

+    cy.createProject(testName);
+    cy.exec(`echo '${JSON.stringify(PVC)}' | oc apply -n ${testName} -f -`);
+    cy.exec(`echo '${JSON.stringify(testerDeployment)}' | oc apply -n ${testName} -f -`);
+    cy.clickNavLink(['Storage', 'Persistent Volume Claims']);


Just a heads up that when #6521 merges, this should be changed to nav.sidenav.clickNavLink(... A bunch of new helper methods added with nav.sidenav.

dtaylor113 · 2020-09-11T16:24:53Z

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts

+  });
+
+  it('Lists Clone', () => {
+    cy.clickNavLink(['Persistent Volume Claims']);


Just a heads up that when #6521 merges, this should be changed to nav.sidenav.clickNavLink(..

dtaylor113 · 2020-09-11T16:40:16Z

Looks like CI timed out waiting for 'Pending' to become 'Bound':

dtaylor113

Looks like CI timed out waiting for 'Pending' to become 'Bound'. Do we need to increase timeout?

cloudbehl · 2020-09-15T16:35:35Z

@dtaylor113 can you review it once again?

dtaylor113

lgtm, thanks

spadgett · 2020-09-18T14:14:28Z

frontend/public/components/utils/request-size-input.tsx

@@ -67,4 +68,5 @@ export type RequestSizeInputProps = {
  minValue?: number;
  inputClassName?: string;
  inputID?: string;
+  testId?: string;


Suggested change

testId?: string;

testID?: string;

dtaylor113 · 2020-09-18T14:17:24Z

/lgtm

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl · 2020-09-21T07:55:31Z

@dtaylor113 Updated the PR to address sam's comment & also added addressed #6528 (review)

dtaylor113 · 2020-09-23T14:03:23Z

/lgtm -thanks

spadgett

/approve

spadgett · 2020-09-23T15:26:31Z

Adding lgtm on behalf of @dtaylor113
/lgtm

@dtaylor113 note nothing can come after lgtm on the line with the bot command :)

openshift-ci-robot · 2020-09-23T15:26:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bipuladh, cloudbehl, dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-09-23T17:28:13Z

@cloudbehl: All pull requests linked via external trackers have merged:

openshift/console#6528

Bugzilla bug 1875770 has been moved to the MODIFIED state.

In response to this:

Bug 1875770: Test for PVC clone

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Sep 4, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality labels Sep 4, 2020

openshift-ci-robot requested review from kyoto and rhamilto September 4, 2020 10:38

bipuladh reviewed Sep 4, 2020

View reviewed changes

frontend/packages/console-app/src/components/modals/clone/clone-pvc-modal.tsx Outdated Show resolved Hide resolved

cloudbehl force-pushed the test_clone branch 2 times, most recently from 32119e0 to b2e6ff0 Compare September 8, 2020 08:49

bipuladh suggested changes Sep 8, 2020

View reviewed changes

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts Outdated Show resolved Hide resolved

frontend/packages/integration-tests-cypress/tests/storage/clone.spec.ts Outdated Show resolved Hide resolved

cloudbehl force-pushed the test_clone branch 2 times, most recently from 13c7723 to b4fd637 Compare September 8, 2020 10:47

bipuladh approved these changes Sep 10, 2020

View reviewed changes

cloudbehl force-pushed the test_clone branch from b4fd637 to f274bf3 Compare September 10, 2020 10:56

bipuladh approved these changes Sep 10, 2020

View reviewed changes

openshift-ci-robot assigned dtaylor113 and spadgett Sep 11, 2020

spadgett reviewed Sep 11, 2020

View reviewed changes

dtaylor113 reviewed Sep 11, 2020

View reviewed changes

dtaylor113 requested changes Sep 11, 2020

View reviewed changes

cloudbehl force-pushed the test_clone branch from f274bf3 to de114e8 Compare September 11, 2020 17:03

dtaylor113 approved these changes Sep 16, 2020

View reviewed changes

spadgett reviewed Sep 18, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020

Test for PVC clone

3de60ca

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

cloudbehl force-pushed the test_clone branch from de114e8 to 3de60ca Compare September 21, 2020 07:53

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020

spadgett approved these changes Sep 23, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020

openshift-merge-robot merged commit 7c601c1 into openshift:master Sep 23, 2020

spadgett added this to the v4.6 milestone Sep 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1875770: Test for PVC clone #6528

Bug 1875770: Test for PVC clone #6528

cloudbehl commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

cloudbehl commented Sep 8, 2020

bipuladh Sep 10, 2020

bipuladh commented Sep 11, 2020

spadgett Sep 11, 2020

spadgett commented Sep 11, 2020

dtaylor113 Sep 11, 2020

cloudbehl Sep 11, 2020

cloudbehl Sep 21, 2020

dtaylor113 Sep 11, 2020

cloudbehl Sep 11, 2020

cloudbehl Sep 21, 2020

dtaylor113 commented Sep 11, 2020

dtaylor113 left a comment

cloudbehl commented Sep 15, 2020

dtaylor113 left a comment

spadgett Sep 18, 2020

cloudbehl Sep 21, 2020

dtaylor113 commented Sep 18, 2020

cloudbehl commented Sep 21, 2020

dtaylor113 commented Sep 23, 2020

spadgett left a comment

spadgett commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

Bug 1875770: Test for PVC clone #6528

Bug 1875770: Test for PVC clone #6528

Conversation

cloudbehl commented Sep 4, 2020

openshift-ci-robot commented Sep 4, 2020

cloudbehl commented Sep 8, 2020

Choose a reason for hiding this comment

bipuladh commented Sep 11, 2020

Choose a reason for hiding this comment

spadgett commented Sep 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtaylor113 commented Sep 11, 2020

dtaylor113 left a comment

Choose a reason for hiding this comment

cloudbehl commented Sep 15, 2020

dtaylor113 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dtaylor113 commented Sep 18, 2020

cloudbehl commented Sep 21, 2020

dtaylor113 commented Sep 23, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020

openshift-ci-robot commented Sep 23, 2020