Bug 1872469: Port login tests from protractor to Cypress #6521

dtaylor113 · 2020-09-03T15:55:07Z

This PR removes most login tests from protractor and adds them to Cypress.

openshift-ci-robot · 2020-09-03T15:55:14Z

@dtaylor113: This pull request references Bugzilla bug 1872469, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1872469: Port login tests from protractor to Cypress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

We need to update test-prow.sh to run the Cypress login spec when login is passed as a parameter. See

https://github.com/openshift/release/blob/024c148b0c0358eb8464c6f0ad5e31b6c304c002/ci-operator/config/openshift/cluster-authentication-operator/openshift-cluster-authentication-operator-master.yaml#L74

frontend/packages/integration-tests-cypress/tests/app/auth-multi-user-login.spec.ts

spadgett · 2020-09-03T16:08:33Z

Hey, Dave. I'm glad we're porting these to Cypress, but we also want to make sure there isn't a real bug in logout that is causing the Protractor tests to fail.

spadgett · 2020-09-03T16:23:33Z

Maybe we'll be able to reproduce with the Cypress tests and get a video to help debug.

dtaylor113 · 2020-09-03T16:26:10Z

Maybe we'll be able to reproduce with the Cypress tests and get a video to help debug.

yes, this PR is just another option and debugging tool, which is why it's a WIP :-)
Wanted to do something to progress https://bugzilla.redhat.com/show_bug.cgi?id=1872469

dtaylor113 · 2020-09-08T21:27:57Z

Just verified protractor's login tests as well as these new Cypress login tests worked multiple times when run locally.

openshift-ci-robot · 2020-09-09T14:29:27Z

@dtaylor113: This pull request references Bugzilla bug 1872469, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

[WIP] Bug 1872469: Port login tests from protractor to Cypress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtaylor113 · 2020-09-09T20:15:21Z

We need to update test-prow.sh to run the Cypress login spec when login is passed as a parameter.

@spadgett Added to bottom of test-prow-e2e.sh:

if [ $# -eq 1 ] && ["$1" == "login" ]; then
  ./test-cypress.sh 'tests/app/auth-multiuser-login.spec.ts'
fi

..and updated test-cypress.sh to run --spec for any passed in arg.

test-prow-e2e.sh

openshift-ci-robot · 2020-09-10T20:29:33Z

@dtaylor113: This pull request references Bugzilla bug 1872469, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872469: Port login tests from protractor to Cypress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

Thanks @dtaylor113. Let's pull the unrelated changes into a separate PR. I don't want to block an important test fix from code comments on the other changes.

frontend/packages/integration-tests-cypress/cypress.json

frontend/packages/integration-tests-cypress/reporter-config.json

spadgett · 2020-09-10T21:38:20Z

frontend/packages/integration-tests-cypress/plugins/index.js

  config.env.BRIDGE_KUBEADMIN_PASSWORD = process.env.BRIDGE_KUBEADMIN_PASSWORD;
+  config.env.appHost = `${process.env.BRIDGE_BASE_ADDRESS || 'http://localhost:9000'}${(


This looks like it's the same as baseUrl. Can we have one config value tracking?

wow, talk about cut & paste blinders :-) sorry, removed appHost.

frontend/packages/integration-tests-cypress/support/index.ts

openshift-ci-robot · 2020-09-11T13:05:30Z

@dtaylor113: This pull request references Bugzilla bug 1872469, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872469: Port login tests from protractor to Cypress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.spec.ts

test-cypress.sh

test-prow-e2e.sh

spadgett · 2020-09-11T18:45:48Z

test-prow-e2e.sh

+elif [ "$SCENARIO" == "login" ]; then
+  ./test-cypress.sh 'tests/app/auth-multiuser-login.spec.ts'
+else
+  ./test-cypress.sh $SCENARIO


This looks wrong... We should not run any cypress tests for other scenarios. You can remove this last else.

Hmm..I can change, but protractor will run with an unknown scenario.

ok, updated

spadgett · 2020-09-11T20:20:39Z

test-prow-e2e.sh

+elif [ "$SCENARIO" == "login" ]; then
+  ./test-cypress.sh 'tests/app/auth-multiuser-login.spec.ts'
+else
+  echo "Cypress: unknown parameter: $1"


Don't echo here. This is expected if you're running a protractor suite. Just remove the else.

Ok, removed

spadgett

/lgtm

Thanks @dtaylor113 !

openshift-ci-robot · 2020-09-11T20:33:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dtaylor113 · 2020-09-11T22:39:22Z

/retest

openshift-ci-robot · 2020-09-12T02:57:05Z

@dtaylor113: All pull requests linked via external trackers have merged:

openshift/console#6521

Bugzilla bug 1872469 has been moved to the MODIFIED state.

In response to this:

Bug 1872469: Port login tests from protractor to Cypress

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dtaylor113 requested review from spadgett and bipuladh September 3, 2020 15:55

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 3, 2020

openshift-ci-robot requested review from TheRealJon and zherman0 September 3, 2020 15:57

spadgett requested changes Sep 3, 2020

View reviewed changes

dtaylor113 force-pushed the move-login-tests-to-cypress branch 2 times, most recently from f3a96d4 to 2c45f76 Compare September 8, 2020 20:32

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 2c45f76 to b8c8d6a Compare September 9, 2020 02:29

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 6ca623b to 67e51a6 Compare September 9, 2020 16:08

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 76e647e to 1518bfa Compare September 9, 2020 20:31

openshift deleted a comment from openshift-ci-robot Sep 9, 2020

dtaylor113 force-pushed the move-login-tests-to-cypress branch 2 times, most recently from 54835de to 141e118 Compare September 10, 2020 14:05

openshift deleted a comment from openshift-ci-robot Sep 10, 2020

spadgett reviewed Sep 10, 2020

View reviewed changes

test-prow-e2e.sh Outdated Show resolved Hide resolved

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 141e118 to 4aa3da7 Compare September 10, 2020 19:50

dtaylor113 changed the title ~~[WIP] Bug 1872469: Port login tests from protractor to Cypress~~ Bug 1872469: Port login tests from protractor to Cypress Sep 10, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2020

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 4aa3da7 to 84af560 Compare September 10, 2020 20:25

spadgett reviewed Sep 10, 2020

View reviewed changes

remove login tests from protractor

f0d0c13

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 84af560 to d23df91 Compare September 11, 2020 13:04

dtaylor113 force-pushed the move-login-tests-to-cypress branch from d23df91 to 97d331b Compare September 11, 2020 13:09

spadgett reviewed Sep 11, 2020

View reviewed changes

frontend/packages/integration-tests-cypress/tests/app/auth-multiuser-login.spec.ts Show resolved Hide resolved

test-cypress.sh Show resolved Hide resolved

test-prow-e2e.sh Outdated Show resolved Hide resolved

dtaylor113 mentioned this pull request Sep 11, 2020

Bug 1875770: Test for PVC clone #6528

Merged

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 97d331b to d5aecdc Compare September 11, 2020 17:42

spadgett requested changes Sep 11, 2020

View reviewed changes

dtaylor113 force-pushed the move-login-tests-to-cypress branch from d5aecdc to 2c73227 Compare September 11, 2020 19:50

spadgett reviewed Sep 11, 2020

View reviewed changes

added 'auth-multi-user-login' test

52986b6

dtaylor113 force-pushed the move-login-tests-to-cypress branch from 2c73227 to 52986b6 Compare September 11, 2020 20:30

spadgett approved these changes Sep 11, 2020

View reviewed changes

openshift-ci-robot assigned spadgett Sep 11, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020

openshift-merge-robot merged commit 8e96822 into openshift:master Sep 12, 2020

spadgett added this to the v4.6 milestone Sep 15, 2020

dtaylor113 deleted the move-login-tests-to-cypress branch September 23, 2020 19:02

dtaylor113 restored the move-login-tests-to-cypress branch September 23, 2020 19:02

dtaylor113 deleted the move-login-tests-to-cypress branch November 25, 2020 14:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1872469: Port login tests from protractor to Cypress #6521

Bug 1872469: Port login tests from protractor to Cypress #6521

dtaylor113 commented Sep 3, 2020 •

edited

openshift-ci-robot commented Sep 3, 2020

spadgett left a comment

spadgett commented Sep 3, 2020

spadgett commented Sep 3, 2020

dtaylor113 commented Sep 3, 2020

dtaylor113 commented Sep 8, 2020

openshift-ci-robot commented Sep 9, 2020

dtaylor113 commented Sep 9, 2020 •

edited

openshift-ci-robot commented Sep 10, 2020

spadgett left a comment

spadgett Sep 10, 2020

dtaylor113 Sep 11, 2020

openshift-ci-robot commented Sep 11, 2020

spadgett Sep 11, 2020

dtaylor113 Sep 11, 2020

dtaylor113 Sep 11, 2020

spadgett Sep 11, 2020

dtaylor113 Sep 11, 2020

spadgett left a comment

openshift-ci-robot commented Sep 11, 2020

dtaylor113 commented Sep 11, 2020

openshift-ci-robot commented Sep 12, 2020

		config.env.BRIDGE_KUBEADMIN_PASSWORD = process.env.BRIDGE_KUBEADMIN_PASSWORD;
		config.env.appHost = `${process.env.BRIDGE_BASE_ADDRESS \|\| 'http://localhost:9000'}${(

Bug 1872469: Port login tests from protractor to Cypress #6521

Bug 1872469: Port login tests from protractor to Cypress #6521

Conversation

dtaylor113 commented Sep 3, 2020 • edited

openshift-ci-robot commented Sep 3, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett commented Sep 3, 2020

spadgett commented Sep 3, 2020

dtaylor113 commented Sep 3, 2020

dtaylor113 commented Sep 8, 2020

openshift-ci-robot commented Sep 9, 2020

dtaylor113 commented Sep 9, 2020 • edited

openshift-ci-robot commented Sep 10, 2020

spadgett left a comment

Choose a reason for hiding this comment

spadgett Sep 10, 2020

Choose a reason for hiding this comment

dtaylor113 Sep 11, 2020

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 11, 2020

spadgett Sep 11, 2020

Choose a reason for hiding this comment

dtaylor113 Sep 11, 2020

Choose a reason for hiding this comment

dtaylor113 Sep 11, 2020

Choose a reason for hiding this comment

spadgett Sep 11, 2020

Choose a reason for hiding this comment

dtaylor113 Sep 11, 2020

Choose a reason for hiding this comment

spadgett left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Sep 11, 2020

dtaylor113 commented Sep 11, 2020

openshift-ci-robot commented Sep 12, 2020

dtaylor113 commented Sep 3, 2020 •

edited

dtaylor113 commented Sep 9, 2020 •

edited