Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text overflow on Catalog tiles w/ long names #669

Merged
merged 1 commit into from
Oct 21, 2018
Merged

Fix text overflow on Catalog tiles w/ long names #669

merged 1 commit into from
Oct 21, 2018

Conversation

jeff-phillips-18
Copy link
Member

Fix is in patternfly-react-extensions version 2.9.6

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640054

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 18, 2018
@spadgett
Copy link
Member

@sosiouxme fyi

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2018
spadgett
spadgett approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2018
@spadgett
Copy link
Member

@jeff-phillips-18 I know @SamiSousa wanted to update patternfly-react as well. We might try to pull this together into one PR to make it easier on @sosiouxme. Are there any other fixes in patternfly-react we might need?

We need to figure out how to automate this since we update dependencies so frequently. I'm going to open a task.

@jeff-phillips-18
Copy link
Member Author

There are a few PRs that need patternfly-react 2.18+
#655 and #666

@jeff-phillips-18
Copy link
Member Author

patternfly-react 2.21.3 also has a fix we would want (side modal overlay animation on firefox)

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2018
spadgett
spadgett approved these changes Oct 18, 2018
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2018
@jeff-phillips-18
Copy link
Member Author

jeff-phillips-18 commented Oct 18, 2018 •
edited
Loading

@sosiouxme Updated package.json to patternfly-react-extensions 2.9.8 to pickup some other necessary fixes.

@rhamilto

@sosiouxme
Copy link
Member

Sorry folks, was not around much today.

@jeff-phillips-18 please include this update to the sources file:

--- a/sources
+++ b/sources
@@ -1,2 +1,2 @@
 401aa1438604b8e32306fa2bd4f8e211  node-v8.9.4-headers.tar.gz
-4d9651a62b920a31ac8733dc63a16940  yarn-offline.tar
+a49c88ab70f7c240d443b51770db791d  yarn-offline.tar

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@jeff-phillips-18
Copy link
Member Author

Updated sources

@spadgett
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2018
@spadgett
Copy link
Member

Service catalog tests will be broken until #670 merges

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2018
@spadgett
Copy link
Member

jenkins rebuild

@openshift-merge-robot openshift-merge-robot merged commit cf9e7c5 into openshift:master Oct 21, 2018
@jeff-phillips-18 jeff-phillips-18 deleted the catalog-tile branch November 19, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeff-phillips-18 @spadgett @sosiouxme @openshift-ci-robot @openshift-merge-robot