Bug 1847074: PF fix for filter bar layout issues at some screen widths on search page

[jcaianirh]

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1847074

After:

[openshift-ci-robot]

@jcaianirh: This pull request references Bugzilla bug 1847074, which is invalid:

• expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1847074: PF fix for filter bar layout issues at some screen widths on search page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcaianirh]

/test analyze

[jcaianirh]

/retest

[jcaianirh]

/retest

[spadgett]

Thanks @jcaianirh. I think we should hold this one for 4.7 due to the PF bump.

[spadgett]

I'm not sure this is right. Are these SVGs? I believe they should be alt.

cc @jessiehuff

[jessiehuff]

Truthfully, svgs are tough, and I've never seen a consensus on that debate between documentation and experts. One of the best comparisons I've seen is from deque (who created Axe) which essentially ends up stating that they found that one solution was not necessarily superior over the other. They cover all combinations of alt, roles, title/desc, and aria, and conclude:

"On the flip side, there was no clear frontrunner for “best in show” for the different patterns when relaying basic alternative content. This is actually good news! Since many of the patterns were able to render the alt content, that equates to more pattern choices for designers and developers. For SVGs needing more descriptive alternative content, pattern 11 <svg> + role="img" + <title> + <desc> + aria-labelledby="[ID]" was the most reliable choice for the different browser and screen readers that were tested."

I've often still recommended alt because it's not just for screen readers, it's frequently used for low bandwidth users as well (when an image can't load, it will show the alt instead). I have read in some articles that svgs have limited support with alt or that it needs role="img" for it to be valid, but it looks like there's a lot of different ways for us to make this accessible. I think if it sounds good in testing, I'm ok with whatever solution we choose.

Some other notable documentation/articles that are interesting to include is this comparison by Scott O'Hara, the more old school recommendations by Leonie Watson (both O'Hara and Watson are considered a11y experts), and the Appendix H on svg accessibility by W3.

[spadgett]

Thanks @jessiehuff. @jcaianirh I'd stick with the existing alt unless there is a specific reason we need to change. Does this cause problems with the new Patternfly version?

[jcaianirh]

@spadgett pf has been updated to support alt tags again. I will put this on hold and update the pr.

patternfly/patternfly-react#4935

[jcaianirh]

/bugzilla refresh

[openshift-ci-robot]

@jcaianirh: This pull request references Bugzilla bug 1847074, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcaianirh]

/hold

[openshift-ci-robot]

@jcaianirh: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/kubevirt-plugin	9c5c0e0	link	/test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[jcaianirh]

/hold cancel

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jcaianirh: All pull requests linked via external trackers have merged:

• openshift/console#6771

Bugzilla bug 1847074 has been moved to the MODIFIED state.

In response to this:

Bug 1847074: PF fix for filter bar layout issues at some screen widths on search page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.