Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added chipGroupMain div, updated snapshots #4873

Merged
merged 3 commits into from
Sep 28, 2020

Conversation

evwilkin
Copy link
Contributor

What: Closes #4404

Adds new <div class="pf-c-chip-group__main"> wrapper element which keeps chip group close button in top-right corner instead of wrapping to new line.

@patternfly-build
Copy link
Contributor

patternfly-build commented Sep 23, 2020

PF4 preview: https://patternfly-react-pr-4873.surge.sh

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #4873 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4873   +/-   ##
=======================================
  Coverage   52.73%   52.73%           
=======================================
  Files         525      525           
  Lines        9453     9453           
  Branches     3478     3478           
=======================================
  Hits         4985     4985           
  Misses       3843     3843           
  Partials      625      625           
Flag Coverage Δ
#patternfly4 52.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../react-core/src/components/ChipGroup/ChipGroup.tsx 90.32% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d008a0...2c81ebd. Read the comment docs.

yarn.lock Outdated Show resolved Hide resolved
Copy link
Contributor

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge until CSS reviews this one.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patternfly-build
Copy link
Contributor

Your changes have been released in:

  • @patternfly/react-catalog-view-extension@4.8.45
  • @patternfly/react-core@4.57.3
  • @patternfly/react-docs@5.9.10
  • @patternfly/react-inline-edit-extension@4.5.101
  • demo-app-ts@4.45.3
  • @patternfly/react-table@4.17.10
  • @patternfly/react-topology@4.6.10
  • @patternfly/react-virtualized-extension@4.5.90

Thanks for your contribution! 🎉

@jcaianirh
Copy link
Contributor

jcaianirh commented Sep 28, 2020

@mcoker @evwilkin @nicolethoen about this solution. I've updated openshift with the fixed component and core as follows:
"@patternfly/patternfly": "4.40", "@patternfly/react-core": "4.57.3",
With no code adjustments, I get the following wrapping behavior:
Screen Shot 2020-09-28 at 5 27 16 PM

Am I meant to update the DataToolbar to use the prop / value combo: <Toolbar collapseListedFiltersBreakpoint="xl" ...
If so I get this behavior:
Screen Shot 2020-09-28 at 5 23 57 PM
Screen Shot 2020-09-28 at 5 23 45 PM

Curious if this is the desired behavior...It seems like the trade off is that we eliminate the chips on a fairly wide view port or keep the wrapped behavior...

My pr: openshift/console#6771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChipGroups: close chip group button wraps at smaller widths
8 participants