-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added chipGroupMain div, updated snapshots #4873
added chipGroupMain div, updated snapshots #4873
Conversation
PF4 preview: https://patternfly-react-pr-4873.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #4873 +/- ##
=======================================
Coverage 52.73% 52.73%
=======================================
Files 525 525
Lines 9453 9453
Branches 3478 3478
=======================================
Hits 4985 4985
Misses 3843 3843
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge until CSS reviews this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Your changes have been released in:
Thanks for your contribution! 🎉 |
@mcoker @evwilkin @nicolethoen about this solution. I've updated openshift with the fixed component and core as follows: Am I meant to update the DataToolbar to use the prop / value combo: Curious if this is the desired behavior...It seems like the trade off is that we eliminate the chips on a fairly wide view port or keep the wrapped behavior... My pr: openshift/console#6771 |
What: Closes #4404
Adds new
<div class="pf-c-chip-group__main">
wrapper element which keeps chip group close button in top-right corner instead of wrapping to new line.