Cover static and dynamic plugin SDKs with unit tests #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
needs-rebase
openshift-ci-robot
added
component/dev-console
vojtechszocs
force-pushed
the
unit-tests-are-good
branch
from
d9a5d64
to
aa74938
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@vojtechszocs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
vojtechszocs
force-pushed
the
unit-tests-are-good
branch
from
aa74938
to
8cf4065
Compare
|
/test e2e-gcp-console |
openshift-ci-robot
added
the
needs-rebase
vojtechszocs
force-pushed
the
unit-tests-are-good
branch
from
8cf4065
to
cf0fe5e
Compare
openshift-ci-robot
added
approved
|
/test e2e-gcp-console |
1 similar comment
|
/test e2e-gcp-console |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code coverage for key parts of both plugin SDKs:
@console/plugin-sdk(primary goal is to support static plugins within the monorepo)@console/dynamic-plugin-sdk(primary goal is to develop and build dynamic plugins)In future, we'll reconcile these packages as part of transforming existing static plugins to dynamic ones.