-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n common components: modals #6887
i18n common components: modals #6887
Conversation
7c40131
to
6d0a903
Compare
6d0a903
to
238a440
Compare
238a440
to
78b5ce6
Compare
@rebeccaalpert: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
78b5ce6
to
2936149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rebeccaalpert !
Addressed feedback; let me know if you have other comments! |
2936149
to
da2f3d2
Compare
Resource Quota test is passing locally. Maybe the test issue is a flake? Trying again. /test e2e-gcp-console |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some nits on TypeScript types
/assign @yapei @ahardin-rh @sferich888 This is ready for testing. |
da2f3d2
to
23bb568
Compare
Addressed about modal, column management modal, edit labels modal, edit pod count modal, edit parallelism modal, managed resource save modal, delete modal, EmptyBox (used in modals), main parts of check annotations modal, taints modal, edit pod selector, tolerations modal, and expand PVC modal.
5b7dbc8
to
35eed04
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
13 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rebeccaalpert, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
Addressed the following modals/components:
It looks like PatternFly adds default aria-labels to many components. We may have to go through and add props so we can pass in translated ones. I haven't addressed this yet.
I skipped the following modals from the shared kebab for now since they're in a package:
I'll circle back and handle those later when I'm further along with the rest of the story.
This is a part of https://issues.redhat.com/projects/CONSOLE/issues/CONSOLE-2416.