Bug 1888985: Fix Cypress test flake and accesibility violation: 'Ensures buttons have discernible text'

[dtaylor113]

2 days ago a a11y PR merged which failes the CI when an accesibility violoation is detected.

Since then there has been a CI accesibility test failure/flake:

    ResourceQuota
      ✓ creates the resource instance (24665ms)
1 accessibility violation was detected for Details page for ResourceQuota: test-gvugd-resource-quota
┌─────────┬───────────────┬────────────┬─────────────────────────────────────────┬───────┐
│ (index) │      id       │   impact   │               description               │ nodes │
├─────────┼───────────────┼────────────┼─────────────────────────────────────────┼───────┤
│    0    │ 'button-name' │ 'critical' │ 'Ensures buttons have discernible text' │   1   │
└─────────┴───────────────┴────────────┴─────────────────────────────────────────┴───────┘
1 accessibility violation was detected for Details page for ResourceQuota: test-gvugd-resource-quota
┌─────────┬───────────────┬────────────┬─────────────────────────────────────────┬───────┐
│ (index) │      id       │   impact   │               description               │ nodes │
├─────────┼───────────────┼────────────┼─────────────────────────────────────────┼───────┤
│    0    │ 'button-name' │ 'critical' │ 'Ensures buttons have discernible text' │   1   │
└─────────┴───────────────┴────────────┴─────────────────────────────────────────┴───────┘
  173 passing (14m)
  1 failing

  1) Kubernetes resource CRUD operations
       ResourceQuota
         displays detail view for newly created resource instance:
     AssertionError: 1 accessibility violation was detected: expected 1 to equal 0
      at Context.eval (https://console-openshift-console.apps.ci-op-11095grj-75d12.origin-ci-int-gce.dev.openshift.com/__cypress/tests?p=tests/crud/k8-openshift-cruds.spec.ts:47956:443712)

Seems to be a race condition/timing issue where a11y check sometimes occures before Details page is fully loaded.

This PR adds a details.isLoaded() helper method and adds a aria-label to the field level help in Resouce Quota Detail's page which displays the (?) icon with no button text.

[openshift-ci-robot]

@dtaylor113: This pull request references Bugzilla bug 1888985, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1888985: Fix Cypress test flake and accesibility violation: 'Ensures buttons have discernible text'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[spadgett]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dtaylor113: All pull requests linked via external trackers have merged:

• openshift/console#6951

Bugzilla bug 1888985 has been moved to the MODIFIED state.

In response to this:

Bug 1888985: Fix Cypress test flake and accesibility violation: 'Ensures buttons have discernible text'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtaylor113]

/cherrypick release-4.6

[openshift-cherrypick-robot]

@dtaylor113: new pull request created: #6981

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.