-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1889529: Check for any CR name versus a specific name #7003
Conversation
@zherman0: An error was encountered adding this pull request to the external tracker bugs for bug 1889529 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, zherman0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/refresh bugzilla |
/bugzilla refresh |
@zherman0: An error was encountered adding this pull request to the external tracker bugs for bug 1889529 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@zherman0: All pull requests linked via external trackers have merged: Bugzilla bug 1889529 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Current code looks for specific name from initialization resource metadata:name value however any named custom resource of that specific type will fulfil the requirements. In the case of this bug, we were looking for
storagecluster-example
but OCS names the storage clusterocs-storagecluster.
We now have a watch that looks for any specific custom resource to be created in order to trigger us to turn off the alert saying it needs to be created.