Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2447: i18n for secrets #7047

Merged
merged 1 commit into from Nov 18, 2020
Merged

CONSOLE-2447: i18n for secrets #7047

merged 1 commit into from Nov 18, 2020

Conversation

zherman0
Copy link
Member

@zherman0 zherman0 commented Oct 29, 2020 •
edited by spadgett

CONSOLE-2447: i18n for secrets
Needs #7045 to merge to be complete.

Also includes a missed translation from the details page component that was found during my testing.

@zherman0
Copy link
Member Author

/assign @spadgett

spadgett
spadgett reviewed Oct 30, 2020
View reviewed changes
frontend/public/components/secret.jsx Outdated Show resolved Hide resolved
frontend/public/components/secret.jsx Outdated Show resolved Hide resolved
frontend/public/components/secret.jsx Outdated Show resolved Hide resolved
@spadgett spadgett added this to the v4.7 milestone Oct 30, 2020
@zherman0 zherman0 force-pushed the secrets-i18n branch 2 times, most recently from 11bc44d to b0cf2c3 Compare October 30, 2020 18:11
@zherman0
Copy link
Member Author

zherman0 commented Nov 2, 2020

/retest

@zherman0
Copy link
Member Author

zherman0 commented Nov 4, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2020
@zherman0
Copy link
Member Author

zherman0 commented Nov 7, 2020

/retest

1 similar comment
@zherman0
Copy link
Member Author

zherman0 commented Nov 7, 2020

/retest

spadgett
spadgett approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2020
@zherman0
Copy link
Member Author

zherman0 commented Nov 9, 2020

/retest

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Nov 10, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@zherman0
Copy link
Member Author

@spadgett - had to rebase due to json conflict

spadgett
spadgett approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2020
@spadgett
Copy link
Member

/retest

2 similar comments
@zherman0
Copy link
Member Author

/retest

@zherman0
Copy link
Member Author

/retest

@spadgett
Copy link
Member

/hold

It looks like the secret tests aren't passing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2020
@zherman0
Copy link
Member Author

@spadgett - Been working on this all morning; the tests all pass locally so I am not sure what if happening.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@zherman0
Copy link
Member Author

@spadgett - Fixed the test cases and rebased.

dtaylor113
dtaylor113 requested changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, one small Cypress fix -thanks

frontend/packages/integration-tests-cypress/views/list-page.ts Outdated Show resolved Hide resolved
dtaylor113
dtaylor113 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, spadgett, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zherman0
Copy link
Member Author

/retest

1 similar comment
@zherman0
Copy link
Member Author

/retest

@zherman0
Copy link
Member Author

/retest

So far we have had annotation flakes and a variety of others.

@spadgett
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2020
@zherman0
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 0a84df9 into openshift:master Nov 18, 2020
@zherman0 zherman0 deleted the secrets-i18n branch November 18, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 dtaylor113 approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@spadgett spadgett

@yapei yapei

@dtaylor113 dtaylor113

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@zherman0 @yanpzhan @ahardin-rh @spadgett @sferich888 @openshift-ci-robot @openshift-bot @dtaylor113 @yapei @openshift-merge-robot